Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accidentals added to the wrong note after tie #472

Closed
WolfgangD opened this issue Dec 21, 2020 · 2 comments · Fixed by #485
Closed

Accidentals added to the wrong note after tie #472

WolfgangD opened this issue Dec 21, 2020 · 2 comments · Fixed by #485
Assignees
Labels
area-rendering Everything related to the rendering state-accepted This is a valid topic to work on. type-improvement 🚀

Comments

@WolfgangD
Copy link

Expected Results

Accidentals after a tie follow this rule.
Untitled 3

In the below example, they are expected to show up for the note corresponding to 6,6 tabs in bar 135.

Observed Results

The accidental is added to the tie target note and could be confuseded with accidentals that apply to the whole bar.
Screenshot 2020-12-21 at 11 37 09

Steps to Reproduce

  1. Load Notation legend bars 134, 135

Your environment

Version

Flavor

  • JavaScript

System

  • Mac OS Big Sur, Safari

options = {
file: filename,
core: {
engine: "svg"
},
player: {
soundFont: "FluidR3GM.sf2",
enableCursor: true,
enablePlayer: true,
enableUserInteraction: false
},
notation: {
elements: {
ScoreTitle: false,
ScoreSubTitle: false,
ScoreArtist: false,
ScoreAlbum: false,
ScoreWords: false,
ScoreMusic: false,
ScoreWordsAndMusic: false,
ScoreCopyright: false,
GuitarTuning: false,
TrackNames: false,
EffectMarker: false,
EffectTempo: false
},
notationMode: 'songbook'
}

@Danielku15 Danielku15 added type-improvement 🚀 area-rendering Everything related to the rendering state-accepted This is a valid topic to work on. and removed type-bug 🕷️ labels Dec 22, 2020
@Danielku15 Danielku15 added this to the 1.2 milestone Dec 22, 2020
@Danielku15
Copy link
Member

I added some small improvements regarding this case. My Notation Legend (version 10) only has 127 bars, do you maybe already have an updated one?

@WolfgangD
Copy link
Author

Yes, we do. Forgot to attach here it is:
Notation_legend_12.gp.zip

This was referenced Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-rendering Everything related to the rendering state-accepted This is a valid topic to work on. type-improvement 🚀
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants