Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grace notes should have some padding in front of them #604

Closed
2 of 6 tasks
Danielku15 opened this issue May 22, 2021 · 1 comment · Fixed by #606
Closed
2 of 6 tasks

Grace notes should have some padding in front of them #604

Danielku15 opened this issue May 22, 2021 · 1 comment · Fixed by #606
Assignees
Labels
area-rendering Everything related to the rendering state-accepted This is a valid topic to work on. type-bug 🕷️

Comments

@Danielku15
Copy link
Member

Expected Results

Grace notes should have some padding in front of them and should not be 100% aligned with the previous note.

Observed Results

Grace Notes stick without a single pixel padding to the previous note. This does not look clean:
image

Steps to Reproduce

https://jsfiddle.net/danielku15/hnv87ugt/

Further details

When bars get stretched via the page layout, this is usually not an issue. But it is an issue if the bar is not stretched. e.g. in the example where the staff is not full. We can likely see this also when using the horizontal layout.

Your environment

Version

  • 1.0
  • 1.1
  • 1.2
  • 1.3-alpha.119
    Flavor
  • JavaScript
  • .net

System
Chrome 90, Win10

@Danielku15
Copy link
Member Author

Update: The issue is actually again the issue that during resize some paddings are lost. The padding is initially as expected, but on resize the grace note jumps closer to the previous note.

@Danielku15 Danielku15 added area-rendering Everything related to the rendering state-accepted This is a valid topic to work on. labels May 22, 2021
@Danielku15 Danielku15 added this to the [v1.3.0] Platform Improvements and Maintenance milestone Nov 4, 2021
@Danielku15 Danielku15 moved this to Done in Version 1.3 Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-rendering Everything related to the rendering state-accepted This is a valid topic to work on. type-bug 🕷️
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant