Lint, add expect_no_error and improve timeout #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added feature
expect_no_error(message, function, exception=BaseException)Tests if the function, when run, does not raise any exception that can be caught by
exception. Generates a failed assertion if not met.Improved feature
@timeout(sec)The wrapped function is again wrapped inside
expect_no_error, so that any exception raised inside the child process can be caught right there. If this happens, generates a failed assertion.Demo
This kumite includes a demo with the two new functions copied into Preloaded. If run as-is, the timed block fails instantly. If run without
raisein solution, the timed block fails by timeout as usual.Related issue
Fixes codewars/codewars-runner-cli#698