Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design for example code accompanying each video #57

Closed
Tracked by #25
shiffman opened this issue Jan 31, 2022 · 7 comments
Closed
Tracked by #25

Design for example code accompanying each video #57

shiffman opened this issue Jan 31, 2022 · 7 comments
Assignees
Labels

Comments

@shiffman
Copy link
Member

Just opening a thread to discuss the current example code, I'm referring to this area:

Screen Shot 2022-01-31 at 2 27 57 PM

For the ml5.js project, we are working on the design for hosting examples, there are some things about it that I like—thumbnail image, short description, etc.

Screen Shot 2022-01-31 at 10 55 52 AM

Screen Shot 2022-01-31 at 10 56 17 AM

I also wonder if the code examples should be more prominent, maybe the default tab or even in the place of the timecodes? I am not sure about this.

@shiffman
Copy link
Member Author

shiffman commented Feb 9, 2022

I would also be curious to see what it looks like with the square p5 logo.

@augustkline
Copy link
Collaborator

Here's a link to some example images & descriptions for a few code examples: Google Sheets

@shiffman
Copy link
Member Author

This is great, thank you @klinegareth!!

@shiffman
Copy link
Member Author

@fdoflorenzano is this good in terms of re-assigning the issue back to get started on implementation?

@fdoflorenzano
Copy link
Collaborator

@shiffman I'll go ahead and assign myself :)

@fdoflorenzano
Copy link
Collaborator

@shiffman I believe this can be closed by the merge of #66, or were there any pending discussions around it?

@shiffman
Copy link
Member Author

@shiffman I believe this can be closed by the merge of #66, or were there any pending discussions around it?

Yes! If anything else comes up, we can open new issues. Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants