Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showcase Page Refinements #945

Open
shiffman opened this issue Feb 21, 2023 · 2 comments
Open

Showcase Page Refinements #945

shiffman opened this issue Feb 21, 2023 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@shiffman
Copy link
Member

Picking up from #501 and #638, here is a list of possible refinements / enhancements for the new Passenger Showcase!

https://thecodingtrain.com/showcase

Individual Passenger Pages

For example: https://thecodingtrain.com/showcase/author/kathy-mcguiness

  • It would be nice to include additional information as headers (name and link to URL) for each passenger, making it feel a bit more like a "profile page"?
  • The "preview" image when sharing a page should grab a passenger showcase thumb rather than the default share image.

Showcase Cards

  • Author links can go to their filtered page (rather than what was entered in the form)?
  • Handle video titles that are cut-off
    • new design over 2 lines?
    • truncate with "..."?
    • other ideas?

Screen Shot 2023-02-21 at 4 52 14 PM Screen Shot 2023-02-21 at 4 52 03 PM

We can use this as a discussion thread and break things out into individual pull requests / issues as needed. Any other thoughts or comments?

@kfahn22
Copy link
Collaborator

kfahn22 commented Feb 22, 2023

RE Name and link to URL. While I like the idea and there might be a one unique URL for an author, that will not always be the case.

Raising a different issue. There are a couple of authors who have contributed under more than one variation of their name and /or contributed a showcase jointly with another person. How do we want to handle this?

@shiffman
Copy link
Member Author

These are very good points!

RE Name and link to URL. While I like the idea and there might be a one unique URL for an author, that will not always be the case.

Yes, since the site is a static build and not database driven what we can do here is quite limited. I think we do our best and just pick the URL from the latest submission for any given author? We can see how that goes and if it doesn't work well, we can try something different.

Raising a different issue. There are a couple of authors who have contributed under more than one variation of their name and /or contributed a showcase jointly with another person. How do we want to handle this?

Different author names will unfortunately show up as different filters/pages with the way the site works. Contributors can go back and edit their names in the JSON files if they want to consolidate the pages. For joint submissions these will end up on their own page since the name is the unique identifier. I'm ok with this for a first try, we can always see if we want to improve the system later!

@shiffman shiffman added the help wanted Extra attention is needed label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants