Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to avoid suggestions about adding comments #318

Closed
esauser opened this issue Sep 21, 2023 · 3 comments
Closed

Attempt to avoid suggestions about adding comments #318

esauser opened this issue Sep 21, 2023 · 3 comments
Labels
enhancement New feature or request solved

Comments

@esauser
Copy link

esauser commented Sep 21, 2023

A lot of the suggestions we get are to add comments. These have not once been helpful. Would you consider additional prompts to avoid suggestions for adding comments?

@mrT23
Copy link
Collaborator

mrT23 commented Sep 21, 2023

We can, i also prefer more insightful suggestions than plain "add comments"

Just for the record, have you tried using the "extra_instructions" field ?
thats its purpose: to enable teams to easily and quickly customize and adjust the output

/improve --pr_code_suggestions.extra_instructions="avoid suggestions about adding comments. "


See a similar example here:
I got suggestions about better handling 'except':
#315 (comment)

let's say I don't care about that.
with
/review --pr_reviewer.extra_instructions="avoid suggestions about better handling exceptions"
I got suggestions focused on other issues:
#315 (comment)

@mrT23 mrT23 added the enhancement New feature or request label Sep 21, 2023
@esauser
Copy link
Author

esauser commented Sep 22, 2023

@mrT23 yes. I opened this issue because I thought it might be worthwhile for everyone to have be a more permanent.

@mrT23
Copy link
Collaborator

mrT23 commented Sep 25, 2023

see #327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request solved
Projects
None yet
Development

No branches or pull requests

2 participants