fix: bug in PR #1189's 'ignore_duplicates' implementation #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jpivarski! From CoffeaTeam/coffea#1080 (comment) this looks like it is going to work, but I'm running the full CI with it now on my fork: https://github.com/matthewfeickert/coffea/actions/runs/8994558805 I'll review here once that's finished. |
|
The one failure is after tests, so I guess this is a success. If all is good tomorrow, let me know and I'll merge this + release a new version of Uproot. |
matthewfeickert
approved these changes
May 8, 2024
There was a problem hiding this comment.
@jpivarski This is all passing for coffea as expected now
the only failure is a docs deployment as I'm on my fork and don't have permissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The duplicate-checking should be checking against the full path, with slashes, not the
branch.name. This passes the same tests as before (the Delphes file had no TBranches nested within TBranches), but it should fix CoffeaTeam/coffea#1080.