Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edison: convert passive sentence to active sentence #181

Open
danyaljj opened this issue Sep 13, 2016 · 6 comments
Open

Edison: convert passive sentence to active sentence #181

danyaljj opened this issue Sep 13, 2016 · 6 comments
Assignees
Labels

Comments

@danyaljj
Copy link
Member

Write sth that converts passive sentences to active ones;
this might be helpful:
https://github.com/rgrishman/jet/blob/52ca610354b9e76d954e62725e0fb56762e674d1/src/main/java/edu/nyu/jet/parser/DepTransformer.java#L233-L260

@danyaljj danyaljj self-assigned this Sep 13, 2016
@aurghob
Copy link
Contributor

aurghob commented Mar 26, 2019

Hi,
Was this or will this be worked on?

@danyaljj
Copy link
Member Author

Nope. Up for grabs.

@aurghob
Copy link
Contributor

aurghob commented Mar 26, 2019

Thanks for the quick response! I'm new to the repository so I'm not sure if I have enough background and time to work on this. Could you comment on what else needs to be known here and what you mean by "sth"? Any other resources that need to looked at? Besides, what would be your approximate estimate on time to be taken on this assuming java understanding and a little bit of NLP experience?

@aurghob
Copy link
Contributor

aurghob commented Mar 26, 2019

Also - would this also work on questions besides normal sentences in the end?

@Slash0BZ
Copy link
Member

Slash0BZ commented Apr 4, 2019

Hi @aurghob, this is not something we are planning to work on in the near future, but you are welcomed to contribute, and we would appreciate it.

To answer your question, I am not entirely sure what's the purpose of the original comment. Given the code in the link above, I am assuming it's a set of hard-coded rules, which shouldn't be too complicated.

I don't know what you mean by sentences in the end. If you can, please give us some details on what your expectations are from this function, some examples would be useful.

@aurghob
Copy link
Contributor

aurghob commented Apr 4, 2019

Its alright if you guys are not looking to take this up right now - I'm looking to use a active to passive and/or passive to active voice converter for questions.
My expectation, for example, is that if a question is present in active voice as "Did John read Cinderella?", I want to change it to something similar to "Was Cinderella read by John?".

Thanks for the guess - I'd assume 1-2 weeks would be fair. I'll try to look into it in that case. Would you have any idea how the relations are generated and what a span might represent here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants