Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not everything should be a property in TextAnnotation #112

Open
shyamupa opened this issue Aug 19, 2018 · 1 comment
Open

Not everything should be a property in TextAnnotation #112

shyamupa opened this issue Aug 19, 2018 · 1 comment
Labels
major change Issues that require major version increment

Comments

@shyamupa
Copy link
Member

ta.get_pos and ta.get_ner should be vanilla methods instead of being properties.

For properties, I suggest have ta.pos and ta.ner if we want that functionality.

@nitishgupta
Copy link
Member

I also agree with Shyam. I don't see a point of having ta.pos style properties. Just functions should suffice. But, if we do so now, a lot of old code will break. What should we do. I don't know of code apart from Lorelei and My-EL that uses cogcomp-nlpy. So this might be a good time before more people start to use this.

@shyamupa shyamupa added the major change Issues that require major version increment label Aug 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major change Issues that require major version increment
Projects
None yet
Development

No branches or pull requests

2 participants