Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text segments in versions are transformed to lowercase #51

Open
dylan-robins opened this issue Mar 20, 2024 · 1 comment
Open

Text segments in versions are transformed to lowercase #51

dylan-robins opened this issue Mar 20, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@dylan-robins
Copy link

When not using entirely numeric version numbers (such as 2.1-PRELIM-03 or 1.3-FINAL-00), the text parts are transformed to lowercase after loading using to_dict (i.e. 2.1-prelim-03 or 1.3-final-00). This means additional logic is required to process them and compare the these with what I have in the other parts of my program.

Is there a reason for this that I have missed, or shall I create a PR to (optionally?) allow users to keep the case provided in the markdown file?

@Colin-b
Copy link
Owner

Colin-b commented Jan 9, 2025

I would say that this is not the expected behavior indeed. Feel free to submit a PR

@Colin-b Colin-b added the bug Something isn't working label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants