Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change build_requires to private_build_requires when appropriate #1

Open
BigRoy opened this issue Nov 26, 2019 · 0 comments
Open

Change build_requires to private_build_requires when appropriate #1

BigRoy opened this issue Nov 26, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@BigRoy
Copy link
Member

BigRoy commented Nov 26, 2019

Issue

Currently in all the packages we've defined build_requires for the build requirements, however in most scenarios this isn't actually correct as only the building of that package X itself requires those and not necessarily any packages that depend on X requires those too for building, as such those would be private_build_requires for X.

See: https://github.com/nerdvegas/rez/wiki/Building-Packages#build-time-dependencies

As example:

  • If package X requires cmake to run the build script then any dependent package does not need cmake, e.g. package Y might just build using make or sconstruct
  • If package X requires visualstudio to build but another does not then this could be private_build_requires.
  • Only whenever the dependent packages is required to build against it, e.g. when project Y headers link to project X headers then to build project Z that links Y it requires the headers of X too.
Z <---- Y <---- X
   links   links
@BigRoy BigRoy added the enhancement New feature or request label Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant