Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] GRAVESTONES_USE_PRIORITY_LIST has become unused. #58

Closed
2 tasks
Bubbus opened this issue Oct 29, 2021 · 0 comments · Fixed by #150
Closed
2 tasks

[Bug] GRAVESTONES_USE_PRIORITY_LIST has become unused. #58

Bubbus opened this issue Oct 29, 2021 · 0 comments · Fixed by #150
Labels
bug Something isn't working
Milestone
1.6.0

Comments

@Bubbus
Copy link
Collaborator

Bubbus commented Oct 29, 2021 •
edited
Loading

The GRAVESTONES_USE_PRIORITY_LIST has become unused by the body manager code, this shouldn't have happened as it's a fairly significant feature. Re-introduce this functionality.

  • When GRAVESTONES_USE_PRIORITY_LIST is enabled, important corpses (players) should be put into a VIP queue and only removed when there is no other choice (aka when body limit is exceeded but there are no non-VIP corpses left to remove).
  • When GRAVESTONES_USE_PRIORITY_LIST is disabled, all corpses are put into the same queue and no special logic is used to decide which corpse is the next to remove.

Thanks to Cre for finding this issue.

Originally posted by @Bubbus in #57 (comment)
@Bubbus Bubbus added the bug Something isn't working label Oct 29, 2021
@Bubbus Bubbus changed the title I don't know how GRAVESTONES_USE_PRIORITY_LIST became unused as it's a fairly significant feature. I'll create a new ticket to re-introduce it. [Bug] GRAVESTONES_USE_PRIORITY_LIST has become unused. Oct 29, 2021
@Bubbus Bubbus added this to the 1.6.0 milestone Feb 28, 2023
@Bubbus Bubbus mentioned this issue Mar 8, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

[Bugfix] - Fixed GRAVESTONES_USE_PRIORITY_LIST being ignored. CombinedArmsGaming/CAFE3
1 participant
@Bubbus