Skip to content

Commit f8ede78

Browse files
authored
Merge branch 'main' into webcam-capture
2 parents af8ad95 + 8b2c1fc commit f8ede78

File tree

107 files changed

+3921
-3514
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

107 files changed

+3921
-3514
lines changed
Lines changed: 69 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,69 @@
1+
---
2+
name: Cloud Backport Tag
3+
4+
on:
5+
pull_request:
6+
types: ['closed']
7+
branches: [cloud/*]
8+
9+
jobs:
10+
create-tag:
11+
if: >
12+
github.event.pull_request.merged == true &&
13+
contains(github.event.pull_request.labels.*.name, 'backport')
14+
runs-on: ubuntu-latest
15+
permissions:
16+
contents: write
17+
pull-requests: read
18+
19+
steps:
20+
- name: Checkout merge commit
21+
uses: actions/checkout@v5
22+
with:
23+
ref: ${{ github.event.pull_request.merge_commit_sha }}
24+
25+
- name: Setup Node.js
26+
uses: actions/setup-node@v5
27+
with:
28+
node-version-file: '.nvmrc'
29+
30+
- name: Create tag for cloud backport
31+
id: tag
32+
run: |
33+
set -euo pipefail
34+
35+
BRANCH="${{ github.event.pull_request.base.ref }}"
36+
if [[ ! "$BRANCH" =~ ^cloud/([0-9]+)\.([0-9]+)$ ]]; then
37+
echo "::error::Base branch '$BRANCH' is not a cloud/x.y branch"
38+
exit 1
39+
fi
40+
41+
MAJOR="${BASH_REMATCH[1]}"
42+
MINOR="${BASH_REMATCH[2]}"
43+
44+
VERSION=$(node -p "require('./package.json').version")
45+
if [[ "$VERSION" =~ ^${MAJOR}\.${MINOR}\.([0-9]+)(-.+)?$ ]]; then
46+
PATCH="${BASH_REMATCH[1]}"
47+
SUFFIX="${BASH_REMATCH[2]:-}"
48+
else
49+
echo "::error::Version '${VERSION}' does not match cloud branch '${BRANCH}'"
50+
exit 1
51+
fi
52+
53+
TAG="cloud/v${VERSION}"
54+
55+
if git ls-remote --tags origin "${TAG}" | grep -Fq "refs/tags/${TAG}"; then
56+
echo "::notice::Tag ${TAG} already exists; skipping"
57+
echo "tag=${TAG}" >> "$GITHUB_OUTPUT"
58+
exit 0
59+
fi
60+
61+
git tag "${TAG}" "${{ github.event.pull_request.merge_commit_sha }}"
62+
git push origin "${TAG}"
63+
echo "tag=${TAG}" >> "$GITHUB_OUTPUT"
64+
{
65+
echo "Created tag: ${TAG}"
66+
echo "Branch: ${BRANCH}"
67+
echo "Version: ${VERSION}"
68+
echo "Commit: ${{ github.event.pull_request.merge_commit_sha }}"
69+
} >> "$GITHUB_STEP_SUMMARY"

.github/workflows/pr-backport.yaml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -236,8 +236,8 @@ jobs:
236236
PR_TITLE=$(echo "$PR_DATA" | jq -r '.title')
237237
MERGE_COMMIT=$(echo "$PR_DATA" | jq -r '.mergeCommit.oid')
238238
else
239-
PR_TITLE="${{ github.event.pull_request.title }}"
240-
MERGE_COMMIT="${{ github.event.pull_request.merge_commit_sha }}"
239+
PR_TITLE=$(jq -r '.pull_request.title' "$GITHUB_EVENT_PATH")
240+
MERGE_COMMIT=$(jq -r '.pull_request.merge_commit_sha' "$GITHUB_EVENT_PATH")
241241
fi
242242
243243
for target in ${{ steps.filter-targets.outputs.pending-targets }}; do
@@ -326,8 +326,8 @@ jobs:
326326
PR_TITLE=$(echo "$PR_DATA" | jq -r '.title')
327327
PR_AUTHOR=$(echo "$PR_DATA" | jq -r '.author.login')
328328
else
329-
PR_TITLE="${{ github.event.pull_request.title }}"
330-
PR_AUTHOR="${{ github.event.pull_request.user.login }}"
329+
PR_TITLE=$(jq -r '.pull_request.title' "$GITHUB_EVENT_PATH")
330+
PR_AUTHOR=$(jq -r '.pull_request.user.login' "$GITHUB_EVENT_PATH")
331331
fi
332332
333333
for backport in ${{ steps.backport.outputs.success }}; do
@@ -364,9 +364,9 @@ jobs:
364364
PR_AUTHOR=$(echo "$PR_DATA" | jq -r '.author.login')
365365
MERGE_COMMIT=$(echo "$PR_DATA" | jq -r '.mergeCommit.oid')
366366
else
367-
PR_NUMBER="${{ github.event.pull_request.number }}"
368-
PR_AUTHOR="${{ github.event.pull_request.user.login }}"
369-
MERGE_COMMIT="${{ github.event.pull_request.merge_commit_sha }}"
367+
PR_NUMBER=$(jq -r '.pull_request.number' "$GITHUB_EVENT_PATH")
368+
PR_AUTHOR=$(jq -r '.pull_request.user.login' "$GITHUB_EVENT_PATH")
369+
MERGE_COMMIT=$(jq -r '.pull_request.merge_commit_sha' "$GITHUB_EVENT_PATH")
370370
fi
371371
372372
for failure in ${{ steps.backport.outputs.failed }}; do

.storybook/main.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ const config: StorybookConfig = {
6464
deep: true,
6565
extensions: ['vue']
6666
})
67-
// Note: Explicitly NOT including generateImportMapPlugin to avoid externalization
6867
],
6968
server: {
7069
allowedHosts: true

CODEOWNERS

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
1+
# Global Ownership
2+
* @Comfy-org/comfy_frontend_devs
3+
14
# Desktop/Electron
2-
/apps/desktop-ui/ @webfiltered
3-
/src/stores/electronDownloadStore.ts @webfiltered
4-
/src/extensions/core/electronAdapter.ts @webfiltered
5-
/vite.electron.config.mts @webfiltered
5+
/apps/desktop-ui/ @benceruleanlu
6+
/src/stores/electronDownloadStore.ts @benceruleanlu
7+
/src/extensions/core/electronAdapter.ts @benceruleanlu
8+
/vite.electron.config.mts @benceruleanlu
69

710
# Common UI Components
811
/src/components/chip/ @viva-jinyi
@@ -31,10 +34,7 @@
3134
/src/components/graph/selectionToolbox/ @Myestery
3235

3336
# Minimap
34-
/src/renderer/extensions/minimap/ @jtydhr88
35-
36-
# Assets
37-
/src/platform/assets/ @arjansingh
37+
/src/renderer/extensions/minimap/ @jtydhr88 @Myestery
3838

3939
# Workflow Templates
4040
/src/platform/workflow/templates/ @Myestery @christian-byrne @comfyui-wiki
@@ -53,7 +53,7 @@
5353
/src/workbench/extensions/manager/ @viva-jinyi @christian-byrne @ltdrdata
5454

5555
# Translations
56-
/src/locales/ @Yorha4D @KarryCharon @shinshin86 @Comfy-Org/comfy_maintainer
56+
/src/locales/ @Yorha4D @KarryCharon @shinshin86 @Comfy-Org/comfy_maintainer @Comfy-org/comfy_frontend_devs
5757

5858
# LLM Instructions (blank on purpose)
5959
.claude/

apps/desktop-ui/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@comfyorg/desktop-ui",
3-
"version": "0.0.3",
3+
"version": "0.0.4",
44
"type": "module",
55
"nx": {
66
"tags": [
-109 Bytes
Loading
-405 Bytes
Loading
1.99 KB
Loading
0 Bytes
Loading
0 Bytes
Loading

0 commit comments

Comments
 (0)