Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Show group titles above #286

Open
rhdunn opened this issue Nov 7, 2024 · 3 comments
Open

[Bug]: Show group titles above #286

rhdunn opened this issue Nov 7, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@rhdunn
Copy link

rhdunn commented Nov 7, 2024

Frontend Version

1.3.26

Expected Behavior

When a noodle/wire passes over a group title, the title text should be clearly visible.

Actual Behavior

When a noodle/wire passes over a group title, the title text is obscured as the noodle is displayed above the group title.

Steps to Reproduce

image

workflow.json

Debug Logs

n/a

Browser Logs

n/a

Setting JSON

{
    "Comfy.NodeLibrary.Bookmarks": [],
    "Comfy.LinkRenderMode": 2,
    "Comfy.UseNewMenu": "Top"
}

What browsers do you use to access the UI ?

Mozilla Firefox

Other

This is more apparent when creating large/complex workflows.

@huchenlei huchenlei transferred this issue from Comfy-Org/ComfyUI_frontend Nov 7, 2024
@webfiltered
Copy link
Collaborator

There are solutions, but none of them elegant. I'll put in something ugly but extension-friendly.

@webfiltered webfiltered added the enhancement New feature or request label Nov 7, 2024
@rhdunn
Copy link
Author

rhdunn commented Nov 7, 2024

You could have multiple rendering passes:

  • background -- grid, groups (backgrounds/bodies)
  • wiring -- noodles/wires
  • components -- nodes, groups (titles)

That would likely be the cleanest approach.

@webfiltered
Copy link
Collaborator

webfiltered commented Nov 7, 2024

I meant the solutions to do this without breaking monkey patches out in the wild are not elegant.

There are already multiple passes. But simply splitting the group render into two phases isn't enough to get legible text:
image

Edit: worth noting.. I accidentally increased the opacity of the title bar, and it's still bad (railing on my own attempt here, not your suggestion). There is a change planned for groups - this could be added as a goal to that.

@webfiltered webfiltered added this to the Group Management milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants