Skip to content

Remove stray "." argument passed to cargo run in RustAppHostingExtension.cs #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alirexaa merged 2 commits into from
Dec 1, 2025
Merged

Remove stray "." argument passed to cargo run in RustAppHostingExtension.cs #1016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35e048c
Initial plan
Copilot Nov 30, 2025
e7a7843
Remove stray "." argument from cargo run in RustAppHostingExtension
Copilot Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/CommunityToolkit.Aspire.Hosting.Rust/RustAppHostingExtension.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ public static IResourceBuilder<RustAppExecutableResource> AddRustApp(this IDistr
ArgumentException.ThrowIfNullOrWhiteSpace(workingDirectory, nameof(workingDirectory));

string[] allArgs = args is { Length: > 0 }
? ["run", ".", .. args]
: ["run", ".",];
? ["run", .. args]
: ["run"];

workingDirectory = Path.Combine(builder.AppHostDirectory, workingDirectory).NormalizePathForCurrentPlatform();
var resource = new RustAppExecutableResource(name, workingDirectory);
Expand Down
4 changes: 1 addition & 3 deletions tests/CommunityToolkit.Aspire.Hosting.Rust.Tests/AddRustAppTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ public async Task AddRustAppAddsAnnotationMetadata()
Assert.Equal("cargo", resource.Command);
var args = await resource.GetArgumentValuesAsync();
Assert.Collection(args,
arg => Assert.Equal("run", arg),
arg => Assert.Equal(".", arg));
arg => Assert.Equal("run", arg));
}

[Fact]
Expand All @@ -50,7 +49,6 @@ public async Task AddRustAppWithArgsAddsAnnotationMetadata()
var args = await resource.GetArgumentValuesAsync();
Assert.Collection(args,
arg => Assert.Equal("run", arg),
arg => Assert.Equal(".", arg),
arg => Assert.Equal("--verbose", arg));
}
}
Loading