Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Enable roaming settings via OneDrive file storage #74

Closed
shweaver-MSFT opened this issue Mar 2, 2021 · 3 comments · Fixed by #85
Closed

[Feature] Enable roaming settings via OneDrive file storage #74

shweaver-MSFT opened this issue Mar 2, 2021 · 3 comments · Fixed by #85
Assignees
Milestone

Comments

@shweaver-MSFT
Copy link
Member

Describe the problem this feature would solve

Related to #72, RoamingSettings have been deprecated by the Windows platform and there is a need for an alternative.

Describe the solution

Integrate with the RoamingSettings constructs of #72 and #73, and create a new OneDriveDataStore to manage roaming settings via files in OneDrive.

var settings = new RoamingSettings(DataStore.OneDrive);

Additional context & Screenshots

There is a working example in Ambie that we can reference:
https://github.com/jenius-apps/ambie/blob/main/src/AmbientSounds/Services/SyncEngine.cs

@ghost ghost added the needs triage 🔍 label Mar 2, 2021
@ghost
Copy link

ghost commented Mar 2, 2021

Hello shweaver-MSFT, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@ghost ghost added the needs attention 👋 label Mar 18, 2021
@ghost
Copy link

ghost commented Mar 18, 2021

This issue has been marked as "needs attention 👋" due to no activity for 15 days. Please triage the issue so the fix can be established.

@shweaver-MSFT
Copy link
Member Author

Work is mostly done, lives here: https://github.com/windows-toolkit/Graph-Controls/tree/shweaver/roaming-onedrive

Waiting on the initial RoamingSettings PR to merge before submitting the PR for this.

@shweaver-MSFT shweaver-MSFT mentioned this issue Mar 23, 2021
9 tasks
@ghost ghost added the In-PR 🚀 label Apr 5, 2021
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Apr 15, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 15, 2021
@shweaver-MSFT shweaver-MSFT added this to the 7.1.0 milestone Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant