Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Labs" moniker from generated "All Component" solution #399

Closed
Arlodotexe opened this issue Mar 9, 2023 · 2 comments · Fixed by #401
Closed

Remove "Labs" moniker from generated "All Component" solution #399

Arlodotexe opened this issue Mar 9, 2023 · 2 comments · Fixed by #401
Assignees
Labels
dev loop ➰ For issues that impact the core dev-loop of building experiments

Comments

@Arlodotexe
Copy link
Member

Arlodotexe commented Mar 9, 2023

Background

The "All Component" solution refers to the solution file generated by GenerateAllSolution.ps1.

Problem

The script generates the Toolkit.Labs.All.sln file, and a number of things that reference it reside inside the ./common folder. This folder contains all our new tooling, and is scheduled to be split into a submodule.

Solution

  1. Create a new name for the "All component" solution file that is
    • Accurate to its purpose
    • Short and easy to understand
    • Generic enough to be used by any repo that consumes our tooling
  2. Update all references to the old name with the new one.
@Arlodotexe Arlodotexe self-assigned this Mar 9, 2023
@Arlodotexe Arlodotexe added the dev loop ➰ For issues that impact the core dev-loop of building experiments label Mar 9, 2023
@Arlodotexe Arlodotexe added this to the Labs Submodule Prep milestone Mar 9, 2023
@michael-hawker
Copy link
Member

Is the only reference to it just here:

$generatedSolutionFilePath = 'Toolkit.Labs.All.sln'

(Outside of all the vscode/devcontainer config files outside of common?)

If so, should we just pass it as an argument to the script? Then we can just put it in the batch file and it can be part of the steps for setting up a new repo?

@Arlodotexe
Copy link
Member Author

Arlodotexe commented Mar 10, 2023

We shouldn't need to parameterize this if the name follows the criteria listed in the op, especially:

Generic enough to be used by any repo that consumes our tooling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev loop ➰ For issues that impact the core dev-loop of building experiments
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants