Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update components to use custom icons #473

Closed
Arlodotexe opened this issue Jul 17, 2023 · 1 comment
Closed

Update components to use custom icons #473

Arlodotexe opened this issue Jul 17, 2023 · 1 comment
Labels
dev loop ➰ For issues that impact the core dev-loop of building experiments

Comments

@Arlodotexe
Copy link
Member

Background

In CommunityToolkit/Tooling-Windows-Submodule#66, we gave components the ability to declare a custom icon to be displayed in the sample app.

In CommunityToolkit/Windows#103, we migrated all non-Labs components to use the component icons.

Problem

Labs has not been updated with this change. If we need to update the Tooling submodule to latest main for any reason, we'll run into this problem as well.

Solution

Update tooling to latest main and finish adding the custom icon to all existing Labs components, including those still in PR.

@Arlodotexe Arlodotexe added the dev loop ➰ For issues that impact the core dev-loop of building experiments label Jul 17, 2023
@Arlodotexe Arlodotexe moved this to 🆕 New in Toolkit 8.x Jul 17, 2023
@Arlodotexe
Copy link
Member Author

This was closed in #451

@Arlodotexe Arlodotexe closed this as not planned Won't fix, can't repro, duplicate, stale Jul 17, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Toolkit 8.x Jul 17, 2023
@Arlodotexe Arlodotexe removed this from Toolkit 8.x Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev loop ➰ For issues that impact the core dev-loop of building experiments
Projects
None yet
Development

No branches or pull requests

1 participant