Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes not suppressed when switching to Uno / WinUI 3 #26

Closed
Arlodotexe opened this issue Mar 20, 2023 · 3 comments
Closed

Changes not suppressed when switching to Uno / WinUI 3 #26

Arlodotexe opened this issue Mar 20, 2023 · 3 comments
Labels
dev loop ➰ For issues that impact the core dev-loop of building experiments regression What was working is now broke

Comments

@Arlodotexe
Copy link
Member

Arlodotexe commented Mar 20, 2023

Background

In CommunityToolkit/Labs-Windows#75, we added a UseUnoWinUI.ps1 script to facilitate switching between Uno.UI and Uno.WinUI.

In #1, we moved this script into a submodule.

Problem

After the move to a submodule, switching to WinUI 3 leaves changed files in the working tree when it didn't before.

This alone isn't an issue since the script-altered files won't get committed alongside the user's normal changes.

However, changing these files causes the parent repo to update the submodule commit hash, which can easily be committed alongside normal changes:

image

Solution

Suppress changes to these files again so the user cannot commit them without explicitly passing the -allowGitChanges flag.

@Arlodotexe Arlodotexe added dev loop ➰ For issues that impact the core dev-loop of building experiments regression What was working is now broke labels Mar 20, 2023
@michael-hawker
Copy link
Member

Don't we need to remove the whole removing from tracking bit? That way when we work on it here, it'll show up to commit and not be hidden?

Would that solve this issue as well? Or do we need two different behaviors depending on if it's being used in a submodule or not?

@Arlodotexe
Copy link
Member Author

Arlodotexe commented Mar 21, 2023

I was hoping that we could when we moved to a submodule, but the problem with that is

However, changing these files causes the parent repo to update the submodule commit hash,
which can easily be committed alongside normal changes.

If the user commits the commit hash but doesn't push it to the submodule's origin, git won't be able to pull it and the submodule won't be cloned.

Sidenote - Most people can't push to the submodule's origin, they'd have to fork it and use their fork instead. The same way they'd fork and use any other repo.

@Arlodotexe
Copy link
Member Author

This is no longer planned but can be reopened at a later date if really needed. We're largely covered because most people can't push to the submodule's origin.

@Arlodotexe Arlodotexe closed this as not planned Won't fix, can't repro, duplicate, stale Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev loop ➰ For issues that impact the core dev-loop of building experiments regression What was working is now broke
Projects
None yet
Development

No branches or pull requests

2 participants