-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes not suppressed when switching to Uno / WinUI 3 #26
Comments
Don't we need to remove the whole removing from tracking bit? That way when we work on it here, it'll show up to commit and not be hidden? Would that solve this issue as well? Or do we need two different behaviors depending on if it's being used in a submodule or not? |
I was hoping that we could when we moved to a submodule, but the problem with that is
If the user commits the commit hash but doesn't push it to the submodule's origin, git won't be able to pull it and the submodule won't be cloned. Sidenote - Most people can't push to the submodule's origin, they'd have to fork it and use their fork instead. The same way they'd fork and use any other repo. |
This is no longer planned but can be reopened at a later date if really needed. We're largely covered because most people can't push to the submodule's origin. |
Background
In CommunityToolkit/Labs-Windows#75, we added a
UseUnoWinUI.ps1
script to facilitate switching between Uno.UI and Uno.WinUI.In #1, we moved this script into a submodule.
Problem
After the move to a submodule, switching to WinUI 3 leaves changed files in the working tree when it didn't before.
This alone isn't an issue since the script-altered files won't get committed alongside the user's normal changes.
However, changing these files causes the parent repo to update the submodule commit hash, which can easily be committed alongside normal changes:
Solution
Suppress changes to these files again so the user cannot commit them without explicitly passing the
-allowGitChanges
flag.The text was updated successfully, but these errors were encountered: