Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some extension classes are not within the right namespace #1140

Closed
edwinvandriel opened this issue May 2, 2017 · 4 comments
Closed

Some extension classes are not within the right namespace #1140

edwinvandriel opened this issue May 2, 2017 · 4 comments

Comments

@edwinvandriel
Copy link
Contributor

I've noticed that some extension classes are not within the Microsoft.Toolkit.Uwp.UI.Extensions namespace.

Extension classes that are not within this namespace but in Microsoft.Toolkit.Uwp.UI are:

  • HyperlinkExtensions
  • ListViewBaseExtensions
  • VisualTreeExtensions
  • WebViewExtensions

The extension classes that are in Microsoft.Toolkit.Uwp.UI.Extensions namespace:

  • ApplicationView 👍
  • StatusBar 👍
  • TitleBar 👍
@Odonno
Copy link
Contributor

Odonno commented May 2, 2017

I am not sure if it is on purpose but I can see on the git history that we removed the Extensions namespace.

I think @hermitdave has an idea.

@hermitdave
Copy link
Contributor

I myself stumbled upon that over the long weekend. I think we should fix that.

@nmetulev
Copy link
Contributor

nmetulev commented May 2, 2017

Agree, I'll add this as part of the breaking changes work for 2.0

@nmetulev
Copy link
Contributor

nmetulev commented Aug 9, 2017

Closing per #1297

@nmetulev nmetulev closed this as completed Aug 9, 2017
@ghost ghost locked as resolved and limited conversation to collaborators Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants