TextBoxMask: binding problem

[gpbicego]

Repro

<StackPanel>
    <TextBox x:Name="TextBox1" Text="{x:Bind SomeInt, Mode=TwoWay}"
             mtuuc:TextBoxMask.Mask="9999" mtuuc:TextBoxMask.PlaceHolder=" " />
    <TextBox x:Name="TextBox2" Text="{x:Bind SomeInt, Mode=TwoWay}"/>
</StackPanel>

public sealed partial class MainPage : INotifyPropertyChanged
{
    private int _someInt = 333;
    public MainPage()
    {
        this.InitializeComponent();
        ((FrameworkElement)Content).DataContext = this;
    }
    public int SomeInt
    {
        get => _someInt;
        set
        {
            if (_someInt == value) return;
            _someInt = value;
            OnPropertyChanged();
        }
    }
    public event PropertyChangedEventHandler PropertyChanged;
    private void OnPropertyChanged([CallerMemberName] string propertyName = null)
    {
        PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));
    }
}

• Change a digit on 'TextBox1'
• Select 'TextBox2'
• Select 'TextBox1' and digit disappears.

[nmetulev]

ping @IbraheemOsama

looks like, from my quick test, that the two way binding does not reflect the content of the textbox once the mask is applied

[IbraheemOsama]

@nmetulev this PR should solve this issue #1216

[nmetulev]

That's great, just tested it with the fix and it seems to work as expected

[gpbicego]

There are still some problems, I resolved by this way:

• Move the block ‘Case change due to Text property is assigned a value (Ex Textbox.Text="value")’ before ‘Delete or backspace is triggered’ block.
• Move the return outside the else block.

            // Case change due to Text property is assigned a value (Ex Textbox.Text="value")
            if (textbox.SelectionStart == 0 && textbox.FocusState == FocusState.Unfocused)
            {
                var displayText = textbox.GetValue(DefaultDisplayTextProperty) as string ?? string.Empty;
                if (string.IsNullOrEmpty(textbox.Text))
                {
                    textbox.Text = displayText;
                }
                else
                {
                    var textboxInitialValue = textbox.Text;
                    textbox.Text = displayText;
                    SetTextBoxValue(textboxInitialValue, textbox, mask, representationDictionary, placeHolderValue[0], 0);
                    textbox.SetValue(OldTextProperty, textbox.Text);
                }
                return;
            }

            // Delete or backspace is triggered

[nmetulev]

ping @IbraheemOsama

[IbraheemOsama]

@gpbicego what is the problems ? can you please elaborate. I you see that your code works please submit a Pull Request with your fix but describe the problem first :)