-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discrepancy between the app and NuGet package. #1592
Comments
Hey @zipswich, IsFirstRun will be available in 2.1, it is not available in 2.0. If you are running the sample app from GitHub, it will contain APIs not yet released. If you want to try out the new stuff before it is released, you can use the pre-release packages |
@nmetulev Thank you for the clarification. I'd like to suggest keeping the Sample app and the current NuGet package consistent. This is how I typically use the toolkit (I suspect many others are similar):
You can see I always start with the sample app. I keep telling people that the toolkit sample app with embedded code and document is the best sample type help for developers that I have ever seen. |
Hey @zipswich, agreed. Are you seeing the API in the app downloaded from the store? When I download the app from the store, I don't see any APIs not available in 2.0. |
@nmetulev Here is the screenshot: |
Ah, I see, it's the documentation. The app automatically get's the latest from GitHub. Agree, this needs to be fixed |
Thanks, @nmetulev I hate to see this leading to extra workload on you folks unless it can be fixed without disrupting the automation. I am wondering if the properties and methods can have labels automatically showing the versions that introduce them. The title bar of the app could show the version (all my UWP apps do ☺). In this case, users know which ones are available and which are coming. |
It's shouldn't be a lot of work to add, I just need to change the sample app to get latest from our docs repo instead of the main repo :) |
@nmetulev I did notice a similar type of issue with the new docs.microsoft.com links. In the BluetoothLEHelper its source code link is pointing to master, but it's been moved since 2.0. |
Good catch, will update that one too |
I'm submitting a...
Current behavior
SystemInformation.IsFirstRun is not available.
Expected behavior
SystemInformation.IsFirstRun is available. the UWP Toolkit app shows this function.
Minimal reproduction of the problem with instructions
Try using SystemInformation.IsFirstRun in code.
Environment
Nuget Package(s):
Microsfot.Toolkit
Package Version(s):
V2.0.0
Windows 10 Build Number:
App min and target version:
Device form factor:
Visual Studio
The text was updated successfully, but these errors were encountered: