Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy between the app and NuGet package. #1592

Closed
5 of 15 tasks
zipswich opened this issue Nov 5, 2017 · 9 comments
Closed
5 of 15 tasks

Discrepancy between the app and NuGet package. #1592

zipswich opened this issue Nov 5, 2017 · 9 comments

Comments

@zipswich
Copy link

zipswich commented Nov 5, 2017

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request <!-- Please file a UserVoice request and include the link below https://wpdev.uservoice.com/forums/110705-universal-windows-platform/category/193402-uwp-community-toolkit -->
[ ] Sample app request
[x] Documentation issue or request
[ ] Question of Support request => Please do not submit support request here, instead see https://github.com/Microsoft/UWPCommunityToolkit/blob/master/contributing.md#question

Current behavior

SystemInformation.IsFirstRun is not available.

Expected behavior

SystemInformation.IsFirstRun is available. the UWP Toolkit app shows this function.

Minimal reproduction of the problem with instructions

Try using SystemInformation.IsFirstRun in code.

Environment

Nuget Package(s):
Microsfot.Toolkit

Package Version(s):
V2.0.0

Windows 10 Build Number:

  • Anniversary Update (14393)
  • Creators Update (15063)
  • Fall Creators Update (16299)
  • Insider Build (xxxxx)

App min and target version:

  • Anniversary Update (14393)
  • Creators Update (15063)
  • Fall Creators Update (16299)
  • Insider Build (xxxxx)

Device form factor:

  • Desktop
  • Mobile
  • Xbox
  • Surface Hub
  • IoT

Visual Studio

  • 2017 15.3
  • 2017 15.4
@nmetulev
Copy link
Contributor

nmetulev commented Nov 5, 2017

Hey @zipswich, IsFirstRun will be available in 2.1, it is not available in 2.0. If you are running the sample app from GitHub, it will contain APIs not yet released. If you want to try out the new stuff before it is released, you can use the pre-release packages

@nmetulev nmetulev closed this as completed Nov 5, 2017
@zipswich
Copy link
Author

zipswich commented Nov 5, 2017

@nmetulev Thank you for the clarification. I'd like to suggest keeping the Sample app and the current NuGet package consistent. This is how I typically use the toolkit (I suspect many others are similar):

  1. Launch the sample app.
  2. Find what I need, read the code and document.
  3. Copy then modify the interested code in my app.

You can see I always start with the sample app. I keep telling people that the toolkit sample app with embedded code and document is the best sample type help for developers that I have ever seen.

@nmetulev
Copy link
Contributor

nmetulev commented Nov 5, 2017

Hey @zipswich, agreed. Are you seeing the API in the app downloaded from the store? When I download the app from the store, I don't see any APIs not available in 2.0.

@zipswich
Copy link
Author

zipswich commented Nov 5, 2017

@nmetulev Here is the screenshot:
image

@nmetulev
Copy link
Contributor

nmetulev commented Nov 6, 2017

Ah, I see, it's the documentation. The app automatically get's the latest from GitHub. Agree, this needs to be fixed

@nmetulev nmetulev reopened this Nov 6, 2017
@nmetulev nmetulev self-assigned this Nov 6, 2017
@nmetulev nmetulev added this to the v2.1 milestone Nov 6, 2017
@zipswich
Copy link
Author

zipswich commented Nov 6, 2017

Thanks, @nmetulev I hate to see this leading to extra workload on you folks unless it can be fixed without disrupting the automation. I am wondering if the properties and methods can have labels automatically showing the versions that introduce them. The title bar of the app could show the version (all my UWP apps do ☺). In this case, users know which ones are available and which are coming.

@nmetulev
Copy link
Contributor

nmetulev commented Nov 6, 2017

It's shouldn't be a lot of work to add, I just need to change the sample app to get latest from our docs repo instead of the main repo :)

@michael-hawker
Copy link
Member

@nmetulev I did notice a similar type of issue with the new docs.microsoft.com links. In the BluetoothLEHelper its source code link is pointing to master, but it's been moved since 2.0.

@nmetulev
Copy link
Contributor

nmetulev commented Nov 6, 2017

Good catch, will update that one too

@ghost ghost locked as resolved and limited conversation to collaborators Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants