Relative links in sample app documentation panel is not working

[Vijay-Nirmal]

I'm submitting a...

• Bug report
• Sample app request

Current behavior

Since we are using MarkdownTextBlock to display the documentation in sample app relative links will not work.

Expected behavior

Work properly with relative links.

[nmetulev]

This might be possible to get working with some of the improvements to MarkdownTextBlock, I'll take a look

[avknaidu]

@nmetulev This should work with #1639

[Vijay-Nirmal]

Can we create a DocFX Flavored Markdown for documentation panel in sample app because docs.microsoft.com uses DocFX.

@nmetulev Is it possible to change GitHub Flavored Markdown to DocFX Flavored Markdown in GitHub?

[nmetulev]

For the MarkdownTextBlock, it is possible, but not likely. It requires changes in the parser and renderer, it's a lot of work for something that would only minimally improve the sample app (and would create breaking changes for actual users of the control)

For GitHub, I don't believe it's possible to change

[Vijay-Nirmal]

@nmetulev Agree

[avknaidu]

This is already working. Should we close this?

[nmetulev]

They are clickable now, but don't actually do anything.

[avknaidu]

what are you trying to achieve here? when you click on AnimationSet link what should happen? Should it open the docs page on browser?

[Vijay-Nirmal]

No, it should go to the corresponding page.

[avknaidu]

But there is no Sample Page in Sample App for Animation Set. What should happen in this case? should it open on browser?

[Vijay-Nirmal]

In 3.0, there will be Sample Page for everything. If the control/helper doesn't have sample then it will be doc only sample page. Any way we can navigate the user to the corresponding page.

[avknaidu]

Yes. Using Deeplink. So if you want the users to go to AnimationSet docs from the link above, all you need to do is Fire LinkClicked Event on Documentation Markdown and Navigate frame to this URI

uwpct://Animations?sample=animationset

So your links will change to [Animation Set](uwpct://Animations?sample=animationset).

only thing I am not sure about is how does it impact docs.microsoft.com

[Vijay-Nirmal]

How does it affect docs.microsoft.com? This is only for Sample App

[gbarcho]

Whats the status?

[Vijay-Nirmal]

It will be done after #1755 PR merged

[lucaasrojas]

@Vijay-Nirmal The PR #1755 has been merged, can we close this issue?

[Vijay-Nirmal]

@lucaasrojas No, we can't. This issue is not fixed (as for as I know) unless @WilliamABradley fixed it in #1755 (I didn't follow the PR since I was busy). It was supposed to be done by me after #1755 PR merge.

[nmetulev]

Links now show up as links but don't work as anchor links. That's something that should be done in the actual MarkdownTextBlock