Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TokenizingTextBox Doesn't inherit CornerRadius #3349

Closed
3 tasks done
LanceMcCarthy opened this issue Jun 15, 2020 · 7 comments · Fixed by #3460
Closed
3 tasks done

TokenizingTextBox Doesn't inherit CornerRadius #3349

LanceMcCarthy opened this issue Jun 15, 2020 · 7 comments · Fixed by #3460
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥

Comments

@LanceMcCarthy
Copy link

LanceMcCarthy commented Jun 15, 2020

Describe the bug

When applying CornerRadius value to the TokenizingTextBox, the value is not applied.

Steps to Reproduce

Add a CornerRadius value to to the control:

<controls:TokenizingTextBox CornerRadius="5"/>

Observe ConerRadius is not applied.

image

Expected behavior

The CornerRadius is applied

Environment

Microsoft.Toolkit.Uwp.UI.Controls 6.1.0

Windows 10 Build Number:

  • May 2020 Update (2020)

Device form factor:

  • Desktop

Visual Studio

  • 2019 (version: 16.6.2)

Solution

Add a TemplateBinding for CornerRadius to the BackgroundVisual Border in the ControlTemplate.

image

Result:

image

If this is approved, I will open a PR with the solution. I would also like to add TemplateBindings for the other Border-based properties as well (BorderThickness, etc)

@LanceMcCarthy LanceMcCarthy added the bug 🐛 An unexpected issue that highlights incorrect behavior label Jun 15, 2020
@ghost ghost added the needs triage 🔍 label Jun 15, 2020
@ghost
Copy link

ghost commented Jun 15, 2020

Hello LanceMcCarthy, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@Kyaa-dost
Copy link
Contributor

Thanks @LanceMcCarthy for highlighting this issue! @marcpems are we good with the changes @LanceMcCarthy is suggesting?

@LanceMcCarthy
Copy link
Author

Apparently this is blocked by microsoft/microsoft-ui-xaml#2556

@ghost ghost added the needs attention 👋 label Jul 1, 2020
@ghost
Copy link

ghost commented Jul 1, 2020

This issue has been marked as "needs attention 👋" due to no activity for 15 days. Please triage the issue so the fix can be established.

@LanceMcCarthy
Copy link
Author

Issue Triaged, blocked by up-level problem.

@ghost
Copy link

ghost commented Jul 16, 2020

This issue has been marked as "needs attention 👋" due to no activity for 15 days. Please triage the issue so the fix can be established.

@LanceMcCarthy
Copy link
Author

Issue Triaged, blocked by up-level problem.

@ghost ghost added the In-PR 🚀 label Sep 1, 2020
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Sep 17, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants