Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize DesignTools projects #3805

Closed
Nirmal4G opened this issue Mar 4, 2021 · 1 comment · Fixed by #3794
Closed

Modernize DesignTools projects #3805

Nirmal4G opened this issue Mar 4, 2021 · 1 comment · Fixed by #3794

Comments

@Nirmal4G
Copy link
Contributor

Nirmal4G commented Mar 4, 2021

Currently the DesignTools projects we have from the PR #3318 is based on the previous Design projects which were legacy project format. There's nothing wrong with it except that it is verbose. As many of the toolkit projects moved to Sdk-style. It's about time that the design projects be converted to a more modern project format that supports far more capabilities when used in VS IDE.

Previously, it was difficult to convert as there was an issue with .NET SDK v3 targets and VS IDE. Now that has been fixed, we can now convert them to Sdk-style. The design projects use WPF to show custom properties provider. Thus, we'll be using Microsoft.NET.Sdk.WindowsDesktop instead. Although, with .NET 5 we don't need to specify the desktop Sdk explicitly, it should also be usable from older v3 Sdk targets.

We want to force the WindowsDesktop SDK to always use WinFX targets from the SDK instead of using the .NET Framework's inbox version as the SDK version contains fixes around enabling PackageReference. In .NET SDK v5, we added an overridable option to always opt-into this behaviour. See dotnet/wpf#2976 and dotnet/wpf#4630

@ghost ghost added the needs triage 🔍 label Mar 4, 2021
@ghost
Copy link

ghost commented Mar 4, 2021

Hello Nirmal4G, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@ghost ghost added the In-PR 🚀 label Mar 4, 2021
@Nirmal4G Nirmal4G changed the title Convert "DesignTools" projects to Sdk-style Convert 'DesignTools' projects to Sdk-style Mar 4, 2021
@ghost ghost removed the needs triage 🔍 label Mar 4, 2021
@michael-hawker michael-hawker added this to the 7.1 milestone Mar 16, 2021
@Nirmal4G Nirmal4G changed the title Convert 'DesignTools' projects to Sdk-style Convert DesignTools projects to Sdk-style Jun 21, 2021
@Nirmal4G Nirmal4G changed the title Convert DesignTools projects to Sdk-style Modernize DesignTools projects Jun 21, 2021
@ghost ghost added the in progress 🚧 label Jun 29, 2021
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Sep 8, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants