Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trouble building from main? #3839

Closed
michael-hawker opened this issue Mar 14, 2021 · 7 comments
Closed

Trouble building from main? #3839

michael-hawker opened this issue Mar 14, 2021 · 7 comments
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior build 🔥
Milestone

Comments

@michael-hawker
Copy link
Member

Describe the bug

Not sure why I'm having trouble as we just shipped bits...

image

Microsoft.Toolkit.Uwp.UI.Controls.Markdown.DesignTools in PlatformTypes.cs L15-18

FYI @Nirmal4G?

Steps to Reproduce

Steps to reproduce the behavior:

  1. Clone repo
  2. build...

Expected behavior

Can build

Environment

Windows 10 Build Number:
- [ ] Fall Creators Update (16299)
- [ ] April 2018 Update (17134)
- [ ] October 2018 Update (17763)
- [ ] May 2019 Update (18362)
- [x] 20H2 (19042)
- [ ] Insider Build (build number: )

App min and target version:
- [ ] Fall Creators Update (16299)
- [ ] April 2018 Update (17134)
- [ ] October 2018 Update (17763)
- [ ] May 2019 Update (18362)
- [ ] May 2020 Update (19041)
- [ ] Insider Build (xxxxx)

Device form factor:
- [ ] Desktop
- [ ] Xbox
- [ ] Surface Hub
- [ ] IoT

Visual Studio 
- [ ] 2017 (version: )
- [ ] 2019 (version: 16.9.1) 
- [ ] 2019 Preview (version: )

Additional context

Not sure what's going on here... tried a git clean too.

Is anyone else seeing this? @RosarioPulella @Kyaa-dost?

@michael-hawker michael-hawker added bug 🐛 An unexpected issue that highlights incorrect behavior build 🔥 labels Mar 14, 2021
@ghost ghost added the needs triage 🔍 label Mar 14, 2021
@ghost
Copy link

ghost commented Mar 14, 2021

Hello michael-hawker, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@Nirmal4G
Copy link
Contributor

Let me check...

Those types come from Windows Metadata reference. Can you see those in the References node under the project in the solution explorer?

Do you also see this with PR #3794?

@michael-hawker
Copy link
Member Author

michael-hawker commented Mar 14, 2021

image

Yeah, seems like it might be having trouble finding required references?

Build started...
1>------ Build started: Project: Microsoft.Toolkit.Uwp.UI.Controls.DataGrid, Configuration: Debug Any CPU ------
1>Microsoft.Toolkit.Uwp.UI.Controls.DataGrid -> C:\code\WindowsCommunityToolkit\Microsoft.Toolkit.Uwp.UI.Controls.DataGrid\bin\Debug\uap10.0.17763\Microsoft.Toolkit.Uwp.UI.Controls.DataGrid.dll
2>------ Build started: Project: Microsoft.Toolkit.Uwp.UI.Controls.DataGrid.DesignTools, Configuration: Debug x86 ------
2>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(2182,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "Windows". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors.
2>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(2182,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "Windows.Foundation.FoundationContract". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors.
2>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(2182,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "Windows.Foundation.UniversalApiContract". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors.
2>C:\code\WindowsCommunityToolkit\Microsoft.Toolkit.Uwp.UI.Controls.Core.Design\Common\PlatformTypes.cs(15,63,15,79): error CS0246: The type or namespace name 'DependencyObject' could not be found (are you missing a using directive or an assembly reference?)
2>C:\code\WindowsCommunityToolkit\Microsoft.Toolkit.Uwp.UI.Controls.Core.Design\Common\PlatformTypes.cs(16,56,16,65): error CS0246: The type or namespace name 'UIElement' could not be found (are you missing a using directive or an assembly reference?)
2>C:\code\WindowsCommunityToolkit\Microsoft.Toolkit.Uwp.UI.Controls.Core.Design\Common\PlatformTypes.cs(17,63,17,79): error CS0246: The type or namespace name 'FrameworkElement' could not be found (are you missing a using directive or an assembly reference?)
2>C:\code\WindowsCommunityToolkit\Microsoft.Toolkit.Uwp.UI.Controls.Core.Design\Common\PlatformTypes.cs(18,54,18,61): error CS0246: The type or namespace name 'Control' could not be found (are you missing a using directive or an assembly reference?)
========== Build: 1 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

Wish it'd tell me what I was actually missing.

Looks like I have .NET SDK 5.0.201 (x64) and Windows SDK 19041...

Ah, I noticed 17763 in the build directory there. That's like the only SDK I don't have installed.

@michael-hawker
Copy link
Member Author

Yup, I was missing the 17763 SDK... 🤦‍♂️ Wish VS was smarter about this, not sure why I only have trouble building this project.

We're all good I think then.

@Rosuavio
Copy link
Contributor

Rosuavio commented May 5, 2021

I am having issues building (Default|Any CPU) from on main again it may be like #3718
The error I saw
37>C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\MSBuild\Microsoft\DesktopBridge\Microsoft.DesktopBridge.targets(689,5): error : Specified EntryPointExe 'UnitTests.XamlIslands.exe' was not found in the project outputs.

@michael-hawker michael-hawker reopened this May 5, 2021
@michael-hawker michael-hawker added this to the 7.1 milestone May 5, 2021
@Rosuavio
Copy link
Contributor

I am having issues building (Default|Any CPU)

I think I meant to write (Debug|Any CPU). Either way I am no longer seeing any local build issues.

@XAML-Knight
Copy link
Contributor

On a clean dev machine, for my initial build of the WCT, I was able to repro the same compilation errors on the PlatformTypes.cs file. After adding the necessary using statements, and doing a full clean & rebuild, I was able to successfully run the Sample App.

The warnings with the references (same as above) still remain, however:
image

@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior build 🔥
Projects
None yet
Development

No branches or pull requests

4 participants