Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning false in ex. before_save does not short circuit save if saved through parent #77

Open
thhermansen opened this issue Oct 9, 2011 · 0 comments

Comments

@thhermansen
Copy link
Contributor

Normally a returned false in before_save etc will cancel the save call, but this is not the case when doing owner.save and and any embedded records return false on callbacks or save() in general. The embedded proxy just simply ignores it when parent_will_be_saved! is called.

It might be a headache to fix this, as we need to "roll back" the state of every embedded records where save() was successful. Oh well, its an issue, si I'll leave it here for now to be remember :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant