Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Dojo 3+ #988

Closed
nicknisi opened this issue Jul 19, 2018 · 4 comments
Closed

Add support for Dojo 3+ #988

nicknisi opened this issue Jul 19, 2018 · 4 comments

Comments

@nicknisi
Copy link
Contributor

🌈 Feature

We're getting close to releasing Dojo v3+ and the big change is the deprecation of the @dojo/core package as it has now been consolidated into the @dojo/framework package. If I remember correctly, the backend looks for the @dojo/core dependency to know which template to use. Could we also have it check for @dojo/framework so that Codesandbox will work with both Dojo 2 and Dojo 3+? Thanks!

@nicknisi nicknisi changed the title Add support for Dojo 3 Add support for Dojo 3+ Jul 19, 2018
@CompuIves
Copy link
Member

@nicknisi
Copy link
Contributor Author

Oh wonderful! I can raise a PR to change that. Thanks for pointing that out!

@agubler
Copy link

agubler commented Jul 27, 2018

Hey @CompuIves, do you know when the PR to support the next major of dojo will be reviewed and released?

@nicknisi
Copy link
Contributor Author

@CompuIves This still seems to be an issue. CodeSandbox doesn't seem to recognize a sandbox as a Dojo template unless @dojo/core is present, but codesandbox/codesandbox-importers#12 added a check for @dojo/framework as well. Do you know if there is anything else we need to do here? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants