Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temperature setting is correct in 0.4.0-rc1 #2698

Closed
PrometheusPi opened this issue Sep 3, 2018 · 6 comments
Closed

Temperature setting is correct in 0.4.0-rc1 #2698

PrometheusPi opened this issue Sep 3, 2018 · 6 comments
Assignees
Labels

Comments

@PrometheusPi
Copy link
Member

After some strange simulation results and an initial offline discussion with @ax3l the question was, whether the temperature setting is still correct.
This question was also mentioned/raised in #2687.

I analyzed the simulations and it looks like setting the temperatures is correct.
Below you can find the results.
Particles have different masses, drift velocities and temperatures.
The transparent colors represent the simulation data (histograms from the macro-particle momentum) while the solid lines represent the expected distribution from the Maxwell-Boltzmann distribution.

equal mass (electron), T_0=50 eV, T_1 = 30 eV, + drifts
image

equal mass (electron), T_0=50 eV, T_1 = 10 eV, + drifts
image

equal mass (electron), T_0=50 eV, T_1 = 5 eV, + drifts
image

different masses (ions), T_0=50 eV, T_1 = 30 eV, + drifts
image

different masses (ions), T_0=50 eV, T_1 = 10 eV, + drifts
image

different masses (ions), T_0=50 eV, T_1 = 5 eV, + drifts
image

(the x-axis represents the velocity normalized to the speed of light, the y-axis is the normalized distribution probability)

@PrometheusPi
Copy link
Member Author

This issue was just opened for future references after discussion it with @psychocoderHPC.
Since there is no error in the current implementation, I will close this issue.

@ax3l
Copy link
Member

ax3l commented Sep 4, 2018

Excellent, thank you for testing and documenting the result. 👍
You tested in 0.4.0-rc2, right?

@PrometheusPi
Copy link
Member Author

No, not quite, I tested it with 0.4.0-rc1.

@ax3l
Copy link
Member

ax3l commented Sep 5, 2018

That's ok as well, rc1 fixed the RNG on CPU, rc2 does contain fixes that do not affect your test: #2686

@ax3l ax3l changed the title Temperature setting is correct in PIConGPU 0.4.0 Temperature setting is correct in PIConGPU 0.4.0-rc1 Sep 5, 2018
@ax3l ax3l changed the title Temperature setting is correct in PIConGPU 0.4.0-rc1 Temperature setting is correct in 0.4.0-rc1 Sep 5, 2018
@PrometheusPi
Copy link
Member Author

PrometheusPi commented Sep 5, 2018

@ax3l Did you mean the 6f172c1e8 Rng: add std::random_device gen fix from alpaka?

@ax3l
Copy link
Member

ax3l commented Sep 5, 2018

yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants