Merge pull request #134 from ComputerScienceHouse/develop

Conditional v1.4.0

Author: liam-middlebrook

conditional/__init__.py

@@ -1,26 +1,30 @@
 import os
 import subprocess
-from flask import Flask
-from flask import redirect
+from flask import Flask, redirect, request, render_template, g
 from flask_sqlalchemy import SQLAlchemy
 from flask_migrate import Migrate
 from csh_ldap import CSHLDAP
+from raven import fetch_git_sha
+from raven.contrib.flask import Sentry
+from raven.exceptions import InvalidGitRepository
 import structlog
 
 app = Flask(__name__)
 
-config = os.path.join(os.getcwd(), "config.py")
+config = os.path.join(app.config.get('ROOT_DIR', os.getcwd()), "config.py")
 
 app.config.from_pyfile(config)
 app.config["SQLALCHEMY_TRACK_MODIFICATIONS"] = False
 
-app.config["GIT_REVISION"] = subprocess.check_output(['git',
-                                                      'rev-parse',
-                                                      '--short',
-                                                      'HEAD']).decode('utf-8').rstrip()
+try:
+    app.config["GIT_REVISION"] = fetch_git_sha(app.config["ROOT_DIR"])[:7]
+except (InvalidGitRepository, KeyError):
+    app.config["GIT_REVISION"] = "unknown"
+
 db = SQLAlchemy(app)
 migrate = Migrate(app, db)
 logger = structlog.get_logger()
+sentry = Sentry(app)
 
 ldap = CSHLDAP(app.config['LDAP_BIND_DN'],
                app.config['LDAP_BIND_PW'],
@@ -52,6 +56,7 @@
 app.register_blueprint(slideshow_bp)
 app.register_blueprint(cache_bp)
 
+from conditional.util.ldap import ldap_get_member
 
 @app.route('/<path:path>')
 def static_proxy(path):
@@ -63,6 +68,42 @@ def static_proxy(path):
 def default_route():
     return redirect('/dashboard')
 
+@app.errorhandler(404)
+@app.errorhandler(500)
+def route_errors(error):
+    data = dict()
+    username = request.headers.get('x-webauth-user')
+
+    # Handle the case where the header isn't present
+    if username is not None:
+        member = ldap_get_member(username)
+        data['username'] = member.uid
+        data['name'] = member.cn
+    else:
+        data['username'] = "unknown"
+        data['name'] = "Unknown"
+
+    # Figure out what kind of error was passed
+    if isinstance(error, int):
+        code = error
+    elif hasattr(error, 'code'):
+        code = error.code
+    else:
+        # Unhandled exception
+        code = 500
+
+    # Is this a 404?
+    if code == 404:
+        error_desc = "Page Not Found"
+    else:
+        error_desc = type(error).__name__
+
+    return render_template('errors.html',
+                            error=error_desc,
+                            error_code=code,
+                            event_id=g.sentry_event_id,
+                            public_dsn=sentry.client.get_public_dsn('https'),
+                            **data), int(code)
 
 @app.cli.command()
 def zoo():

conditional/blueprints/attendance.py

@@ -80,7 +80,7 @@ def get_non_alumni_non_coop(internal=False):
     for account in active_members:
         if account.uid in coop_members:
             # Members who are on co-op don't need to go to house meeting.
-            pass
+            continue
 
         eligible_members.append(
             {
@@ -91,8 +91,8 @@ def get_non_alumni_non_coop(internal=False):
 
     if internal:
         return eligible_members
-    else:
-        return jsonify({'members': eligible_members}), 200
+
+    return jsonify({'members': eligible_members}), 200
 
 
 @attendance_bp.route('/attendance/cm_members')
@@ -314,15 +314,15 @@ def alter_house_attendance(uid, hid):
         member_meeting.attendance_status = "Attended"
         db.session.commit()
         return jsonify({"success": True}), 200
-    else:
-        freshman_meeting = FreshmanHouseMeetingAttendance.query.filter(
-            FreshmanHouseMeetingAttendance.fid == uid,
-            FreshmanHouseMeetingAttendance.meeting_id == hid
-        ).first()
 
-        freshman_meeting.attendance_status = "Attended"
-        db.session.commit()
-        return jsonify({"success": True}), 200
+    freshman_meeting = FreshmanHouseMeetingAttendance.query.filter(
+        FreshmanHouseMeetingAttendance.fid == uid,
+        FreshmanHouseMeetingAttendance.meeting_id == hid
+    ).first()
+
+    freshman_meeting.attendance_status = "Attended"
+    db.session.commit()
+    return jsonify({"success": True}), 200
 
 
 @attendance_bp.route('/attendance/alter/hm/<uid>/<hid>', methods=['POST'])

conditional/blueprints/conditional.py

@@ -117,5 +117,5 @@ def conditional_delete(cid):
         db.session.flush()
         db.session.commit()
         return jsonify({"success": True}), 200
-    else:
-        return "Must be evals director to delete!", 401
+
+    return "Must be evals director to delete!", 401

conditional/blueprints/intro_evals.py

@@ -9,6 +9,7 @@
 
 from conditional.models.models import FreshmanCommitteeAttendance
 from conditional.models.models import MemberCommitteeAttendance
+from conditional.models.models import CommitteeMeeting
 from conditional.models.models import FreshmanAccount
 from conditional.models.models import FreshmanEvalData
 from conditional.models.models import FreshmanHouseMeetingAttendance
@@ -33,11 +34,13 @@ def display_intro_evals(internal=False):
     # get user data
     def get_uid_cm_count(member_id):
         return len([a for a in MemberCommitteeAttendance.query.filter(
-            MemberCommitteeAttendance.uid == member_id)])
+            MemberCommitteeAttendance.uid == member_id)
+            if CommitteeMeeting.query.filter(CommitteeMeeting.id == a.meeting_id).approved])
 
     def get_fid_cm_count(member_id):
         return len([a for a in FreshmanCommitteeAttendance.query.filter(
-            FreshmanCommitteeAttendance.fid == member_id)])
+            FreshmanCommitteeAttendance.fid == member_id)
+            if CommitteeMeeting.query.filter(CommitteeMeeting.id == a.meeting_id).approved])
 
     user_name = None
     if not internal:
@@ -88,7 +91,8 @@ def get_fid_cm_count(member_id):
                 [s.name for s in TechnicalSeminar.query.filter(
                     TechnicalSeminar.id.in_(
                         [a.seminar_id for a in FreshmanSeminarAttendance.query.filter(
-                            FreshmanSeminarAttendance.fid == fid.id)]
+                            FreshmanSeminarAttendance.fid == fid.id)
+                            if TechnicalSeminar.query.filter(TechnicalSeminar.id == a.seminar_id).approved]
                     ))
                  ],
             'social_events': '',
@@ -141,7 +145,8 @@ def get_fid_cm_count(member_id):
                 [s.name for s in TechnicalSeminar.query.filter(
                     TechnicalSeminar.id.in_(
                         [a.seminar_id for a in MemberSeminarAttendance.query.filter(
-                            MemberSeminarAttendance.uid == uid)]
+                            MemberSeminarAttendance.uid == uid)
+                            if TechnicalSeminar.query.filter(TechnicalSeminar.id == a.seminar_id).approved]
                     ))
                  ],
             'social_events': freshman_data.social_events,
@@ -160,9 +165,9 @@ def get_fid_cm_count(member_id):
 
     if internal:
         return ie_members
-    else:
-        # return names in 'first last (username)' format
-        return render_template(request,
-                               'intro_evals.html',
-                               username=user_name,
-                               members=ie_members)
+
+    # return names in 'first last (username)' format
+    return render_template(request,
+                           'intro_evals.html',
+                           username=user_name,
+                           members=ie_members)

conditional/blueprints/intro_evals_form.py

@@ -6,6 +6,7 @@
 from conditional.models.models import FreshmanEvalData
 from conditional.models.models import EvalSettings
 from conditional.util.ldap import ldap_is_intromember
+from conditional.util.ldap import ldap_get_member
 from conditional.util.flask import render_template
 
 from conditional import db
@@ -23,8 +24,8 @@ def display_intro_evals_form():
 
     # get user data
     user_name = request.headers.get('x-webauth-user')
-
-    if not ldap_is_intromember(user_name):
+    account = ldap_get_member(user_name)
+    if not ldap_is_intromember(account):
         return redirect("/dashboard")
     eval_data = FreshmanEvalData.query.filter(
         FreshmanEvalData.uid == user_name).first()

conditional/blueprints/major_project_submission.py

@@ -121,5 +121,5 @@ def major_project_delete(pid):
         db.session.flush()
         db.session.commit()
         return jsonify({"success": True}), 200
-    else:
-        return "Must be project owner to delete!", 401
+
+    return "Must be project owner to delete!", 401

conditional/blueprints/member_management.py

@@ -373,13 +373,13 @@ def get_hm_date(hm_id):
                 'missed_hm': hms_missed,
                 'user': 'eval'
             }), 200
-    else:
-        return jsonify(
-            {
-                'name': account.cn,
-                'active_member': ldap_is_active(account),
-                'user': 'financial'
-            }), 200
+
+    return jsonify(
+        {
+            'name': account.cn,
+            'active_member': ldap_is_active(account),
+            'user': 'financial'
+        }), 200
 
 
 @member_management_bp.route('/manage/user/<fid>', methods=['DELETE'])

conditional/blueprints/spring_evals.py

@@ -6,6 +6,7 @@
 from conditional.util.ldap import ldap_get_active_members
 
 from conditional.models.models import MemberCommitteeAttendance
+from conditional.models.models import CommitteeMeeting
 from conditional.models.models import MemberHouseMeetingAttendance
 from conditional.models.models import MajorProject
 from conditional.models.models import HouseMeeting
@@ -28,7 +29,8 @@ def display_spring_evals(internal=False):
 
     def get_cm_count(member_id):
         return len([a for a in MemberCommitteeAttendance.query.filter(
-            MemberCommitteeAttendance.uid == member_id)])
+            MemberCommitteeAttendance.uid == member_id)
+            if CommitteeMeeting.query.filter(CommitteeMeeting.id == a.meeting_id).approved])
 
     user_name = None
     if not internal:
@@ -87,6 +89,14 @@ def get_cm_count(member_id):
                     MajorProject.uid == uid)]
         }
         member['major_projects_len'] = len(member['major_projects'])
+        member['major_project_passed'] = [
+            {
+                'name': p.name,
+                'status': p.status,
+                'description': p.description
+            } for p in MajorProject.query.filter(MajorProject.uid == uid)
+            if p.status == "Passed"]
+        member['major_projects_passed_len'] = len(member['major_projects_passed'])
         member['major_project_passed'] = False
         for mp in member['major_projects']:
             if mp['status'] == "Passed":
@@ -103,8 +113,8 @@ def get_cm_count(member_id):
     # return names in 'first last (username)' format
     if internal:
         return sp_members
-    else:
-        return render_template(request,
-                               'spring_evals.html',
-                               username=user_name,
-                               members=sp_members)
+
+    return render_template(request,
+                           'spring_evals.html',
+                           username=user_name,
+                           members=sp_members)

conditional/templates/base.html

@@ -23,8 +23,14 @@
             {% block body %}
             {% endblock %}
         {% else %}
-        <div class="container main">
-            <div class="alert alert-danger" role="alert"><span class="glyphicon glyphicon-remove-sign"></span> Site Lockdown: Evaluations in progress. Please check back later.</div>
+        <div class="container main error-page align-center">
+            <div class="col-xs-12">
+                <img src="/static/images/material_lock.svg" alt="Attention!">
+                <h1>Congratulations or I'm Sorry...</h1>
+                <h2>We cannot reveal the results of your evaluation!</h2>
+                <h3>Evaluations underway:</h3>
+                <p>Conditional is in Lockdown</p>
+            </div>
         </div>
         {% endif %}
 

conditional/templates/errors.html

@@ -0,0 +1,19 @@
+{% extends "nav.html" %}
+{% block title %}Error {{ error_code }}{% endblock %}
+{% block body %}
+<div class="container main error-page align-center">
+    <div class="col-xs-12">
+        <img src="/static/images/material_attention.svg" alt="Attention!">
+        <h1>Congratulations or I'm Sorry...</h1>
+        <h2>Something has gone terribly wrong!</h2>
+        <h3>{{ error }}</h3>
+        {% if event_id %}
+        <p>The error identifier is: {{ event_id }}</p>
+        {% endif %}
+    </div>
+    {% if event_id %}
+    <button type="button" class="btn btn-primary" data-module="errorReport" data-event="{{ event_id }}">Report this Error</button>
+    {% endif %}
+</div>
+
+{% endblock %}

conditional/templates/intro_evals.html

@@ -45,12 +45,12 @@ <h6 class="eval-uid">{{ m['uid'] }}</h6>
                             <div class="text-center">
                                 {% if m['signatures_missed'] == 0 %}
                                     <div class="eval-info-label">
-                                        <span class="glyphicon glyphicon-ok-sign green eval-info-status"></span>Sigantures Missed
+                                        <span class="glyphicon glyphicon-ok-sign green eval-info-status"></span>Signatures Missed
                                         <span class="eval-info-number">{{ m['signatures_missed'] }}</span>
                                     </div>
                                 {% elif m['signatures_missed'] > 0 %}
                                     <div class="eval-info-label">
-                                        <span class="glyphicon glyphicon-remove-sign red eval-info-status"></span>Sigantures Missed
+                                        <span class="glyphicon glyphicon-remove-sign red eval-info-status"></span>Signatures Missed
                                         <span class="eval-info-number">{{ m['signatures_missed'] }}</span>
                                     </div>
                                 {% else %}

conditional/templates/major_project_submission.html

@@ -11,15 +11,17 @@ <h3 class="page-title">Major Project Form</h3>
             <div class="panel-body">
                 <div class="form-group label-floating is-empty">
                     <label class="control-label" for="name">Project Name</label>
-                    <input class="form-control" id="name" name="name" type="text" maxlength="64">
+                    <input class="form-control" id="name" name="name" type="text" maxlength="64"
+                     placeholder="A clever name for your project, sometimes people will come up with an acronym.">
                 </div>
             </div>
         </div>
         <div class="panel panel-default">
             <div class="panel-body" style="padding-top:20px;">
                 <div class="form-group label-floating is-empty">
                     <label class="control-label" for="description">Description</label>
-                    <textarea name="description" class="form-control" rows="3" id="description"></textarea>
+                    <textarea name="description" class="form-control" rows="3" id="description"
+                     placeholder="A 'two liner' description of what your project is. If you have source materials like a GitHub repo publicly available, it's also useful to include links to them."></textarea>
                 </div>
             </div>
         </div>
@@ -79,7 +81,7 @@ <h5 style="padding:15px 20px;float:right"><span class="glyphicon glyphicon-hourg
             {% endif %}
             </div>
             <button class="btn-expand-panel" role="button" data-toggle="collapse" href="#evalsCollapse-{{p['id']}}" aria-expanded="false" aria-controls="evalsCollapse-{{p['id']}}"><span class="glyphicon glyphicon glyphicon-menu-down"></span></button>
-            <div class="collapse" id="evalsCollapse-{{p['id']}}">
+            <div class="collapse major-project-desc" id="evalsCollapse-{{p['id']}}">
                 {{p['description']}}
             </div>
         </div>

conditional/templates/spring_eval_slideshow.html

@@ -31,17 +31,17 @@ <h3>{{m['house_meetings_missed']|length}}</h3>
             </div>
           </div>
           <div class="col-xs-12 col-md-4">
-            {% set major_projects_passed = m['major_projects_len'] >= 1 %}
-            <div class="item{% if major_projects_passed %} passed{% endif %}">
-              <span class="icon glyphicon glyphicon-{% if major_projects_passed %}ok passed{%else%}remove{% endif %}" aria-hidden="true"></span>
-              <h3>{{m['major_projects_len']}}</h3>
+            {% set major_projects_passed = m['major_projects_passed_len'] >= 1 %}
+            <div class="item{% if major_projects_passed_len %} passed{% endif %}">
+              <span class="icon glyphicon glyphicon-{% if major_projects_passed_len %}ok passed{%else%}remove{% endif %}" aria-hidden="true"></span>
+              <h3>{{m['major_projects_passed_len']}}</h3>
               <p>Major Projects</p>
             </div>
           </div>
         </div>
         <h4>Major Projects:
-        {% for i in range(m['major_projects_len']) %}
-          {{ m['major_projects'][i]['name'] }}{% if i < m['major_projects_len'] - 1 %}, {% endif %}
+        {% for i in range(m['major_projects_passed_len']) %}
+          {{ m['major_projects_passed'][i]['name'] }}{% if i < m['major_projects_passed_len'] - 1 %}, {% endif %}
         {% endfor %}
         </h4>
 

conditional/util/flask.py

@@ -40,7 +40,7 @@ def render_template(request, template_name, **kwargs):
     ts_review = len(TechnicalSeminar.query.filter(
         TechnicalSeminar.approved == False).all()) # pylint: disable=singleton-comparison
 
-    if is_eval:
+    if is_eboard:
         lockdown = False
 
     return flask_render_template(

conditional/util/ldap.py

@@ -88,8 +88,7 @@ def ldap_is_financial_director(account):
 
 
 def ldap_is_eval_director(account):
-    # TODO FIXME Evaulations -> Evaluations
-    return _ldap_is_member_of_directorship(account, 'Evaulations')
+    return _ldap_is_member_of_directorship(account, 'Evaluations')
 
 
 def ldap_is_current_student(account):
@@ -103,6 +102,8 @@ def ldap_set_housingpoints(account, housing_points):
 
 
 def ldap_set_roomnumber(account, room_number):
+    if room_number == "":
+        room_number = None
     account.roomNumber = room_number
     ldap_get_current_students.cache_clear()
     ldap_get_member.cache_clear()

config.sample.py

@@ -1,7 +1,9 @@
 import os
+from raven import fetch_git_sha
 
 # Flask config
 DEBUG = True
+ROOT_DIR = os.path.dirname(__file__)
 HOST_NAME = 'localhost'
 APP_NAME = 'conditional'
 IP = '0.0.0.0'
@@ -12,6 +14,13 @@
 LDAP_BIND_DN = 'cn=conditional,ou=Apps,dc=csh,dc=rit,dc=edu'
 LDAP_BIND_PW = ''
 
+# Sentry config
+# Do not set the DSN for local development
+SENTRY_CONFIG = {
+    'dsn': '',
+    'release': fetch_git_sha(ROOT_DIR),
+}
+
 # Database config
 SQLALCHEMY_DATABASE_URI = 'sqlite:///{}'.format(os.path.join(os.getcwd(), "data.db"))
 ZOO_DATABASE_URI = 'mysql+pymysql://user:pass@host/database'

frontend/images/material_attention.svg

@@ -1,3 +1,15 @@
+// Install Raven to send errors to Sentry
+import Raven from 'raven-js';
+Raven
+    .config('https://151ecfab1a8242009012d45a19064cfd@sentry.io/133175')
+    .install();
+
+// Capture unhandled exceptions in promises
+window.addEventListener('unhandledrejection', err => {
+  Raven.captureException(err.reason);
+});
+
+// Load the rest of the modules
 import "jquery";
 import "bootstrap";
 import "./modules";

frontend/images/material_lock.svg

@@ -0,0 +1,19 @@
+import Raven from 'raven-js';
+
+export default class ErrorReport {
+  constructor(btn) {
+    this.btn = btn;
+    this.eventId = this.btn.dataset.event;
+    this.render();
+  }
+
+  render() {
+    this.btn.addEventListener('click', () => this._invokeRavenModal());
+  }
+
+  _invokeRavenModal() {
+    Raven.showReportDialog({
+      eventId: this.eventId
+    });
+  }
+}

frontend/javascript/app.js

@@ -22,7 +22,9 @@
 @import 'pages/dashboard';
 @import 'pages/evals';
 @import 'pages/housing';
+@import 'pages/major-project';
 @import 'pages/management';
 @import 'pages/hm-attendance';
 @import 'pages/attendance-hist';
+@import 'pages/errors';
 @import 'components/reveal';

frontend/javascript/modules/errorReport.js

@@ -0,0 +1,35 @@
+.error-page {
+  padding-top: 80px;
+
+  .glyphicon,
+  h1,
+  h2,
+  h3,
+  p {
+    color: #878787;
+  }
+
+  img {
+    margin-bottom: 40px;
+    width: 200px;
+  }
+
+  h1 {
+    font-size: 50px;
+    font-weight: bolder;
+  }
+
+  h2 {
+    margin-bottom: 50px;
+    font-size: 30px;
+  }
+
+  h3 {
+    font-size: 25px;
+  }
+
+  p {
+    font-size: 15px;
+    font-weight: lighter;
+  }
+}

frontend/stylesheets/app.scss

@@ -0,0 +1,3 @@
+.major-project-desc {
+  white-space: pre-line;
+}

frontend/stylesheets/pages/_errors.scss

@@ -1,3 +1,7 @@
+.navbar-fixed-bottom, .navbar-fixed-top {
+  z-index: 900;
+}
+
 .sub-header {
   border-bottom: 1px solid #eee;
   padding-bottom: 10px;
@@ -68,7 +72,7 @@ tr {
 .footer-version {
   display: block;
   opacity: .3;
-  margin: 10px auto 20px;
+  margin: 50px auto 20px;
   text-align: center;
   color: #000;
   font-size: .9em;

frontend/stylesheets/pages/_major-project.scss

@@ -89,6 +89,7 @@
     "object-assign": "4.1.0",
     "open": "0.0.5",
     "pretty-hrtime": "1.0.2",
+    "raven-js": "^3.9.2",
     "require-dir": "0.3.0",
     "sinon": "1.17.4",
     "sinon-chai": "2.8.0",

frontend/stylesheets/partials/_global.scss

@@ -9,4 +9,5 @@ structlog
 flask_sqlalchemy
 flask_migrate
 pylint
-psycopg2
+#psycopg2
+raven[flask]