Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Years Earlier Than 1994 Are Excluded From the Year Menu #99

Closed
adamhb123 opened this issue Aug 13, 2021 · 0 comments · Fixed by #107
Closed

Years Earlier Than 1994 Are Excluded From the Year Menu #99

adamhb123 opened this issue Aug 13, 2021 · 0 comments · Fixed by #107

Comments

@adamhb123
Copy link
Member

adamhb123 commented Aug 13, 2021

Due to:

{% for y in range (info.current_year, 1993, -1) %}

Realistically, this is an inherent issue with the design of the year nav dropdown. This problem will only get worse as more and more years pass (as we will have more and more years to include), and we're already excluding 1993. Though, I'm unsure if that is intended or if the author of the above code was unaware of range's end-exclusivity, as AFAIS 1993 is the last year with a decent cluster of accounts associated with it.

As stated, the real issue is that overtime this list will just get larger and larger. It would be optimal to implement a different method for year selection. There are many solutions that could be used. Bootstrap has a range input selector that could be placed in the dropdown paired with a submit button to effectively do the same thing, or there could just be a text input box as well.

This is tangentially related to #19 , but I think having the year selection in the navbar on every page is a useful feature. As it currently stands, I find an advanced search to be somewhat unnecessary (though, it would certainly be a net positive if properly implemented).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant