Skip to content

Commit d9da558

Browse files
committed
Revert changes to search_tags in favor of changes from TagStudioDev#604
1 parent 6fb1d4b commit d9da558

File tree

3 files changed

+11
-18
lines changed

3 files changed

+11
-18
lines changed

tagstudio/src/core/library/alchemy/library.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
)
3939
from ...enums import LibraryPrefs
4040
from .db import make_tables
41-
from .enums import FieldTypeEnum, FilterState, TagColor, TagFilterState
41+
from .enums import FieldTypeEnum, FilterState, TagColor
4242
from .fields import (
4343
BaseField,
4444
DatetimeField,
@@ -489,7 +489,7 @@ def search_library(
489489

490490
def search_tags(
491491
self,
492-
filter_state: TagFilterState,
492+
name: str,
493493
) -> list[Tag]:
494494
"""Return a list of Tag records matching the query."""
495495
with Session(self.engine) as session:
@@ -499,11 +499,11 @@ def search_tags(
499499
selectinload(Tag.aliases),
500500
)
501501

502-
if filter_state.search:
502+
if name:
503503
query = query.where(
504504
or_(
505-
Tag.name.icontains(filter_state.search),
506-
Tag.shorthand.icontains(filter_state.search),
505+
Tag.name.icontains(name),
506+
Tag.shorthand.icontains(name),
507507
)
508508
)
509509

@@ -513,7 +513,7 @@ def search_tags(
513513

514514
logger.info(
515515
"searching tags",
516-
search=filter_state,
516+
search=name,
517517
statement=str(query),
518518
results=len(res),
519519
)

tagstudio/src/qt/modals/tag_database.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
QWidget,
1313
)
1414
from src.core.library import Library, Tag
15-
from src.core.library.alchemy.enums import TagFilterState
1615
from src.qt.modals.build_tag import BuildTagPanel
1716
from src.qt.widgets.panel import PanelModal, PanelWidget
1817
from src.qt.widgets.tag import TagWidget
@@ -70,9 +69,9 @@ def update_tags(self, query: str | None = None):
7069
while self.scroll_layout.itemAt(0):
7170
self.scroll_layout.takeAt(0).widget().deleteLater()
7271

73-
tags = self.lib.search_tags(TagFilterState(search=query, page_size=self.tag_limit))
72+
tags_results = self.lib.search_tags(name=query)
7473

75-
for tag in tags:
74+
for tag in tags_results:
7675
container = QWidget()
7776
row = QHBoxLayout(container)
7877
row.setContentsMargins(0, 0, 0, 0)

tagstudio/src/qt/modals/tag_search.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
QWidget,
1818
)
1919
from src.core.library import Library
20-
from src.core.library.alchemy.enums import TagFilterState
2120
from src.core.palette import ColorType, get_tag_color
2221
from src.qt.widgets.panel import PanelWidget
2322
from src.qt.widgets.tag import TagWidget
@@ -73,18 +72,13 @@ def on_return(self, text: str):
7372
self.search_field.setFocus()
7473
self.parentWidget().hide()
7574

76-
def update_tags(self, name: str | None = None):
75+
def update_tags(self, query: str | None = None):
7776
while self.scroll_layout.count():
7877
self.scroll_layout.takeAt(0).widget().deleteLater()
7978

80-
found_tags = self.lib.search_tags(
81-
TagFilterState(
82-
search=name,
83-
page_size=self.tag_limit,
84-
)
85-
)
79+
tag_results = self.lib.search_tags(name=query)
8680

87-
for tag in found_tags:
81+
for tag in tag_results:
8882
if self.exclude is not None and tag.id in self.exclude:
8983
continue
9084
c = QWidget()

0 commit comments

Comments
 (0)