-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-sig signing of ContractUpdate transactions #296
Comments
I think this is a duplicate of #38 not just related to it. What I imagined would be simplest and would work reasonably well is to be able to do the following
where the client will tell you "we don't have signers 0:2 and 0:3, the output is only a partially signed transaction. Then we would add an additonal subcommand to
This would display the partially signed transaction So this would work generically for any transaction. |
The full flow would be: Step 1: I suggest adding an optional
Alternativly, adding a new
Step 2: Adding additional signatures with
Step 3: Submitting the fully signed transaction on chain:
|
So the issue is that you will then need multiple "sign" commands, because the transactions are not all under the "transaction" command, e.g., contract updates are under contract, baker stuff is under baker. I don't think this is a good solution. We already have almost all the options with the existing commands, so it's better to refine it. It'll also be much more straightforward to implement because all "transaction" command share the same command line parser and options. |
The introduction of the The current flow would be: Step 1: Signig the transaction but not sending it on-chain
Step 2: Adding additional signatures with
Step 3: Submitting the fully signed transaction on-chain:
|
closing since it is implemented now |
Task description
Concordium has support for native multi-sig accounts. The goal is to make this feature easily accessible. In particular, person A should be able to sign (not sign and send) a transaction with
concordium-client
and person B should be able to append/pass-in its own signature when signing_and_sending a transaction on-chain.Using the multi-sig accounts feature via SDK is currently possible (a bit hacky):
https://gist.github.com/DOBEN/683fe1a7c82a0551546a7ec242d30cc0
Related to:
#38
The text was updated successfully, but these errors were encountered: