Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Computing expiry #44

Open
bisgardo opened this issue Apr 27, 2024 · 0 comments
Open

Computing expiry #44

bisgardo opened this issue Apr 27, 2024 · 0 comments
Labels
[Type] Task An additional feature or improvement.

Comments

@bisgardo
Copy link
Contributor

Currently we just accept expiry as a TransactionTime (unix timestamp). In the examples we use the dummy value 9,999,999,999 which is slightly ridiculous.

We should at least change the examples to use now+5min. But preferably the SDK itself would include an ergonomic way of providing the expiry time (for example an enum with cases for absolute time and for duration into the future).
@bisgardo bisgardo added the [Type] Task An additional feature or improvement. label Apr 27, 2024
@mh-concordium mh-concordium added the [Res] works as designed The functionality is as intended. label May 13, 2024 — with Linear
@mh-concordium mh-concordium removed the [Res] works as designed The functionality is as intended. label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Task An additional feature or improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bisgardo @mh-concordium