Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for page.setExtraHTTPHeaders() #9

Open
tollmanz opened this issue Apr 2, 2018 · 0 comments
Open

Add support for page.setExtraHTTPHeaders() #9

tollmanz opened this issue Apr 2, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@tollmanz
Copy link
Contributor

tollmanz commented Apr 2, 2018

Users should be able to set any headers they want when making a request and recording a timeline. Let's add support for page.setExtraHTTPHeaders() so these headers can be customized.

This is a fairly straight forward task; however, we need to decide on a good UI for adding headers via the command line. setExtraHTTPHeaders takes an object, which is a pain for a user to define via the CLI. I think we might want something like:

# cURL style
--set-extra-http-headers "referer: https://bar.com" --set-extra-http-headers "origin: foo.com" 

# List style
--set-extra-http-headers "referer: https://bar.com,origin: foo.com" 
@tollmanz tollmanz added the enhancement New feature or request label Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant