Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptance tests: prevent deadlocks in tests for async writes #26

Open
hariso opened this issue Jun 8, 2022 · 2 comments
Open

Acceptance tests: prevent deadlocks in tests for async writes #26

hariso opened this issue Jun 8, 2022 · 2 comments
Assignees

Comments

@hariso
Copy link
Contributor

hariso commented Jun 8, 2022

Feature description

In two of our tests for async writes, we are waiting for all the ack functions to be called. To prevent deadlocks, we need to specify a timeout, so that tests do not wait indefinitely, in cases where there's actually a bug in the connector code.

@hariso
Copy link
Contributor Author

hariso commented Jun 9, 2022

I actually faced this when working on async writes for the Kafka connector. I didn't call the ack functions, the acceptance test was stuck, and it wasn't immediately clear why. The fix is a quick one.

@hariso hariso self-assigned this Jun 9, 2022
@neovintage neovintage removed the triage Needs to be triaged label Jul 6, 2022
@neovintage
Copy link
Contributor

This doesn't happen often enough to be material. Will look into this again if it becomes more of a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants