Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use WP variables for path to base compiling folder #219

Merged
merged 15 commits into from
Oct 19, 2021
Merged

Use WP variables for path to base compiling folder #219

merged 15 commits into from
Oct 19, 2021

Conversation

shadoath
Copy link
Collaborator

@shadoath shadoath commented Sep 8, 2021 •
edited
Loading

Fixes #196, where database contained information about WP install location. This caused issues when migrating to another server.

Possible additional work:

  • Auto update values instead of admin callout to save.
  • Keep order to Base Location dropdown

Closes: #196 & #198

@shadoath shadoath added the fix label Sep 11, 2021
This was referenced Sep 30, 2021
Closed
Closed
@mikekchristensen
Copy link

Tested - and this fix works!

@shadoath shadoath merged commit 7b95397 into master Oct 19, 2021
@shadoath shadoath deleted the sb-use-wp-compiling-folder branch October 19, 2021 21:57
@shadoath shadoath mentioned this pull request Oct 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pushing Site from Local to Online Environment (and the reverse) Resets Base Location Setting
2 participants
@shadoath @mikekchristensen