Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sswu fp generic rebased #147

Merged
merged 48 commits into from
Feb 8, 2022
Merged

Sswu fp generic rebased #147

merged 48 commits into from
Feb 8, 2022

Conversation

Tabaie
Copy link
Contributor

@Tabaie Tabaie commented Feb 4, 2022

Created a new branch due to some annoying conflicts. Copying unresolved comments from #130 .

@Tabaie Tabaie changed the base branch from master to develop February 4, 2022 20:19
@Tabaie Tabaie marked this pull request as ready for review February 4, 2022 20:21
@Tabaie Tabaie requested review from gbotrel and yelhousni and removed request for gbotrel February 4, 2022 20:21

parameters.MinSuccessfulTests = 1
properties = gopter.NewProperties(parameters)
properties.Property("inv(0) == 0", prop.ForAll(invMatchExp, ggen.OneConstOf(testPairElement{})))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this do?

@gbotrel
Copy link
Collaborator

gbotrel commented Feb 7, 2022

looks great 🎉 . Close both PR (the outdated one and this one) when done 👍

Copy link
Collaborator

@yelhousni yelhousni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Tabaie Tabaie merged commit 6864b02 into develop Feb 8, 2022
@Tabaie Tabaie deleted the sswu-fp-generic-rebased branch February 8, 2022 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants