Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean: replace modulus generated by constants, add zero-alloc SetRandom #194

Merged
merged 21 commits into from
May 25, 2022
Merged

clean: replace modulus generated by constants, add zero-alloc SetRandom #194

merged 21 commits into from
May 25, 2022

Conversation

gbotrel
Copy link
Collaborator

@gbotrel gbotrel commented May 25, 2022

  • clean: remove unused fuzz test files
  • refactor: remove Add Sub Double x86 asm impl
  • refactor: remove neg x86 impl
  • fix: no carry field generation path
  • docs: clean up and cosmetics
  • fix: fix previous commit
  • docs: cosmetics changes
  • style: simplyfing inverse in field element
  • style: cosmetics changes in field element
  • fix: ensure SetInterface(nil) doesn't panic
  • test: added IsUint64 test in field element
  • feat: use crypto/rand.Int for field.SetRandom
  • fix: remove dead code
  • test: use SetRandom instead of rand.read
  • style: cosmetics
  • build: restore golangci config
  • feat: added zero alloc SetRandom and replace hardcoded modulus words with constants
  • fix: correct endianess in SetRandom

gbotrel added 21 commits May 23, 2022 11:24
@gbotrel
clean: remove unused fuzz test files
6faefba
@gbotrel
refactor: remove Add Sub Double x86 asm impl
059094f
@gbotrel
refactor: remove neg x86 impl
388ad2b
@gbotrel
fix: no carry field generation path
fa798ff
@gbotrel
docs: clean up and cosmetics
8d8ff6a
@gbotrel
fix: fix previous commit
2e8c75d
@gbotrel
docs: cosmetics changes
08095e3
@gbotrel
style: simplyfing inverse in field element
7907b4e
@gbotrel
style: cosmetics changes in field element
56ce237
@gbotrel
fix: ensure SetInterface(nil) doesn't panic
dedc4e2
@gbotrel
test: added IsUint64 test in field element
6ec5da0
@gbotrel
feat: use crypto/rand.Int for field.SetRandom
3a468b0
@gbotrel
fix: remove dead code
ebaac16
@gbotrel
Merge branch 'develop' into cleanup
bb320ca
@gbotrel
test: use SetRandom instead of rand.read
de3eb72
@gbotrel
style: cosmetics
b5c0365
@gbotrel
Merge branch 'develop' into cleanup
6093963
@gbotrel
build: restore golangci config
213c8c5
@gbotrel
feat: added zero alloc SetRandom and replace hardcoded modulus words …
9c00663 
…with constants
@gbotrel
fix: correct endianess in SetRandom
e0494be
@gbotrel
Merge branch 'develop' into feat/setrandom
142c44d
@gbotrel gbotrel merged commit b6caa5f into develop May 25, 2022
@gbotrel gbotrel deleted the feat/setrandom branch May 25, 2022 19:52
@gbotrel gbotrel mentioned this pull request Aug 3, 2022
Merged
ivokub pushed a commit to ivokub/gnark-crypto that referenced this pull request Sep 8, 2023
@ThomasPiellard
fix: removed seed from mimc (fixes Consensys#194)
13a5294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gbotrel