Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fp12: improved cyclotomicSquare #25

Merged
merged 1 commit into from
Jan 7, 2021
Merged

fp12: improved cyclotomicSquare #25

merged 1 commit into from
Jan 7, 2021

Conversation

gbotrel
Copy link
Collaborator

@gbotrel gbotrel commented Jan 7, 2021 •
edited
Loading

see fq12.go tempalte --> removed one MulByNonResidueInv (cancelling with MulByNonResidue) and used E2 squaring (significantly faster than e2 mul) in fp4square .

on my machine:

benchmark              old ns/op     new ns/op     delta
BenchmarkPairing-8     903356        827455        -8.40%
BenchmarkPairing-8     907516        823723        -9.23%

yelhousni
yelhousni approved these changes Jan 7, 2021
View reviewed changes
Copy link
Collaborator

@yelhousni yelhousni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbotrel gbotrel merged commit f3df6a5 into develop Jan 7, 2021
@gbotrel gbotrel deleted the csquare branch January 7, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yelhousni yelhousni yelhousni approved these changes

@ThomasPiellard ThomasPiellard Awaiting requested review from ThomasPiellard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbotrel @yelhousni