Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For FS commitments it is needed to hash to fr, so I'm moving the
hashToFp
code from the HashToCurve modules into every Fp package.One concern is that the hash function uses some
ExpandMsgXmd
function, elsewhere in the gnark-crypto codebase. So as it stands field packages can no longer by copy-pasted into other projects without importing gnark-crypto.