feat: introduce field.Vector #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tabaie
approved these changes
Jan 26, 2023
| @@ -2313,7 +2325,7 @@ func (z *Element) matchVeryBigInt(aHi uint64, aInt *big.Int) error { | |||
|
|
|||
| slice := append(z[:], aHi) | |||
|
|
|||
| return field.BigIntMatchUint64Slice(&aIntMod, slice) | |||
| return bigIntMatchUint64Slice(&aIntMod, slice) | |||
There was a problem hiding this comment.
Maybe we can start getting rid of some of the tests for subcomponents of the Pornin inverse algo not that it's been a while and it seems to work.
There was a problem hiding this comment.
yep, even more so that... the pornin Inverse has this "fallback" mechanism to call the inverseExp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
each
fieldpackage now exposes aVector([]Element) object, which implements the following interfaces:It replaces the
plookup.Tableobject ingnark-crypto, should probably use inecc/Encoderfunctions, and will be the underlying representation of a zkSNARK witness ingnark.