Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: field.BigIntPool.Put() allows nil value #316

Closed
gbotrel opened this issue Jan 26, 2023 · 0 comments
Closed

bug: field.BigIntPool.Put() allows nil value #316

gbotrel opened this issue Jan 26, 2023 · 0 comments
Assignees
@gbotrel
Labels
bug Something isn't working
Milestone
v0.10.0

Comments

@gbotrel
Copy link
Collaborator

gbotrel commented Jan 26, 2023 •
edited
Loading

some big.Int operation mutates the receiver and set it to nil (like ModInverse) .

So a code like

v := pool.Get()
v.ModInverse(...)
pool.Put(v)

May put a nil value into the pool.
@gbotrel gbotrel added this to the v0.10.0 milestone Jan 26, 2023
@gbotrel gbotrel added the bug Something isn't working label Jan 26, 2023
@gbotrel gbotrel self-assigned this Feb 6, 2023
gbotrel added a commit that referenced this issue Feb 6, 2023
@gbotrel
fix: closes #316 big int pool doesn't allow nil values
3169a17
@gbotrel gbotrel closed this as completed Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbotrel gbotrel

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.10.0
Development

No branches or pull requests
1 participant
@gbotrel