Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: KZG verification uses JointScalarMultiplication #493

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

yelhousni
Copy link
Collaborator

Description

Replace two ScalarMultiplication by a JointScalarMultiplication in KZG verification.

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

kzg package tests pass.

How has this been benchmarked?

saves ~1%

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@yelhousni yelhousni added the perf label Mar 26, 2024
@yelhousni yelhousni added this to the v0.10.0 milestone Mar 26, 2024
@yelhousni yelhousni self-assigned this Jun 12, 2024
@yelhousni
Copy link
Collaborator Author

ping @ThomasPiellard :)

@yelhousni yelhousni merged commit e557ad0 into master Jun 20, 2024
6 checks passed
@yelhousni yelhousni deleted the perf/kzg-verify branch June 20, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants