Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ECDSA error types #497

Merged
merged 4 commits into from
Apr 23, 2024
Merged

feat: ECDSA error types #497

merged 4 commits into from
Apr 23, 2024

Conversation

ivokub
Copy link
Collaborator

@ivokub ivokub commented Apr 12, 2024

Description

This PR returns error constants when ECDSA signature is invalid due to r^3 + ax + b being quadratic non-residue. This is used in gnark for handling edge cases. This also allows to make an internal method private.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@yelhousni yelhousni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to merge 👍

@yelhousni yelhousni merged commit 7edca0e into master Apr 23, 2024
7 checks passed
@yelhousni yelhousni deleted the feat/ecdsa-errors branch April 23, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants