perf(ecc): optimize affine Add, Sub and Double #509
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently for affine
Add
,Sub
andDouble
, we convert both points to Jacobian coordinates and do the arithmetic there. Instead, in this PR, we convert only one point and do mixed arithmetic. Formulas forAddMixed
are already implemented in gnark-crypto and here we add the implementation ofDoubleMixed
as per EFD.Type of change
How has this been tested?
2*P == double(P) + P - P
which checks all theAdd
,Sub
andDouble
affine methods.How has this been benchmarked?
e.g. BLS12-381 G1 and G2 additions on a M1 macbook Air:
Checklist:
golangci-lint
does not output errors locally