Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update runner and go version #531

Merged
merged 9 commits into from
Aug 27, 2024
Merged

build: update runner and go version #531

merged 9 commits into from
Aug 27, 2024

Conversation

gbotrel
Copy link
Collaborator

@gbotrel gbotrel commented Aug 27, 2024

bump to go v1.23 and update runner on CI

@gbotrel gbotrel requested a review from ivokub August 27, 2024 14:11
ivokub
ivokub approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. Maybe we also need to update golangici-lint? Locally with v1.56.1 it seems to be working, but it is compiled with go 1.21

@gbotrel gbotrel merged commit 8031ce4 into master Aug 27, 2024
7 checks passed
@gbotrel gbotrel deleted the build/updaterunner branch August 27, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivokub ivokub ivokub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbotrel @ivokub