Issue 1004 - prevent "Mining too far in future" message when using allowedfutureblocktime parameter
#1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the future" when nodes are not in time sync. Also fix issue where zero value of AllowedFutureBlockTime is always shown when using `admin.nodeInfo.protocols.istanbul` in console.
… issue-1004-fix-mining-too-far-in-future
prd-fox
approved these changes
Jun 29, 2020
Krish1979
approved these changes
Jun 30, 2020
|
@jbhurat please review for IBFT implementation. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1004
--allowedfutureblocktimeflag is set, then it's value should also be used when creating a block to prevent "Mining too far in the future" message and associated 2 second wait.Additionally:
ChainConfig.IstanbulConfig.AllowedFutureBlockTime, so that it's not displayed byadmin.nodeInfo.protocols.istanbulwith zero value