Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pmt sendTransaction #25

Merged

Conversation

SatpalSandhu61
Copy link
Contributor

@SatpalSandhu61 SatpalSandhu61 commented Sep 2, 2021

Added new API method eth.sendGoQuorumTransaction(). This performs similar function to eth.sendTransaction(), however it adds support for Privacy Marker Transactions (PMT) in GoQuorum, returning the receipt for the internal private transaction, rather than the receipt for the PMT.

Currently only in DRAFT review until we're happy with the changes.

@chaals
Copy link

chaals commented Sep 2, 2021

Isn't this use case met by eea_sendTransaction (and friends - raw transactions, async methods)?

Copy link
Contributor

@nicolae-leonte-go nicolae-leonte-go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardolyn ricardolyn merged commit 0ed71ef into Consensys:master Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants