Vertx 4 deprecation fixes #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…supported" for uint64 Variable names still need updating Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…or uint64 This follows same validation rules as the teku UInt64Deserializer. Rename variables to match RouterBuilder type. Make OpenApiSpecsExtractorTest fail upon lack of uint64 validator by calling createRouter() (and registering a noop securityHandler to satisfy the eth2 keymanager openapi spec's security scheme). Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…idator by calling createRouter() (and registering a noop securityHandler to satisfy the eth2 keymanager openapi spec's security scheme). Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
usmansaleem
reviewed
Feb 7, 2022
…andle relative ref paths Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…ised as absolute paths by vertx Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…nt64 validator by calling createRouter() (and registering a noop securityHandler to satisfy the eth2 keymanager openapi spec's security scheme)." This reverts commit 5a7f3e7. Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…an now handle relative ref paths" This reverts commit 34ba00d. Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…on-fixes Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
siladu
added
the
TeamCerberus
jframe
reviewed
Feb 17, 2022
jframe
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration from deprecated
vertx-web-api-contractmodule tovertx-web-openapi, see https://vert-x3.github.io/vertx-4-migration-guide/index.html#changes-in-vertx-openapi_changes-in-common-componentsMain change was replacing OpenAPI3RouterFactory with RouterBuilder with near one-for-one method replacements.
Fix "format not supported" bug by adding custom string format validator for uint64. This follows same validation rules as the teku UInt64Deserializer.
Make OpenApiSpecsExtractorTest fail upon lack of uint64 validator by calling createRouter() (and registering a noop securityHandler to satisfy the eth2 keymanager openapi spec's security scheme).